Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(720)

Issue 2569843002: Remove duplicated code in PresentationServiceDelegateImplTest (Closed)

Created:
4 years ago by takumif
Modified:
4 years ago
Reviewers:
mark a. foltz
CC:
chromium-reviews, feature-media-reviews_chromium.org, media-router+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove duplicated code in PresentationServiceDelegateImplTest This CL takes media sources, mock listeners, and render frame IDs that were being declared repeatedly in individual test cases, and makes them properties of the main PresentationServiceDelegateImplTest class. BUG=673437 Committed: https://crrev.com/db922919b12172876644b800ae0d6d1a0c0d2d23 Cr-Commit-Position: refs/heads/master@{#438360}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -128 lines) Patch
M chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc View 22 chunks +97 lines, -128 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
takumif
Please take a look, thanks!
4 years ago (2016-12-12 20:01:49 UTC) #4
mark a. foltz
lgtm Thanks.
4 years ago (2016-12-13 23:36:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2569843002/1
4 years ago (2016-12-14 00:25:57 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-14 00:31:46 UTC) #14
commit-bot: I haz the power
4 years ago (2016-12-14 00:35:32 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/db922919b12172876644b800ae0d6d1a0c0d2d23
Cr-Commit-Position: refs/heads/master@{#438360}

Powered by Google App Engine
This is Rietveld 408576698