Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 2569833002: [DevTools] Fix Cookie Sort (Closed)

Created:
4 years ago by phulce
Modified:
4 years ago
Reviewers:
dgozman
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

[DevTools] Fix Cookie Sort Adjust CookiesTable comparator to get the correct property for string comparisons. BUG=671251 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2550213002 Cr-Commit-Position: refs/heads/master@{#437605} (cherry picked from commit 6cbb9199efb2e4996c77e67982cf8a55bed4df3d) Review-Url: https://codereview.chromium.org/2569833002

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -2 lines) Patch
A third_party/WebKit/LayoutTests/inspector/components/cookies-table.html View 1 chunk +57 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/components/cookies-table-expected.txt View 1 chunk +13 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/components_lazy/CookiesTable.js View 1 chunk +10 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
phulce
Needs lgtm from a committer
4 years ago (2016-12-12 19:35:41 UTC) #2
dgozman
lgtm
4 years ago (2016-12-12 19:47:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2569833002/1
4 years ago (2016-12-12 19:48:57 UTC) #6
commit-bot: I haz the power
4 years ago (2016-12-12 19:53:38 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698