Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1525)

Issue 2569813003: Clang toolchain: link Gold plugin with lld. (Closed)

Created:
4 years ago by krasin1
Modified:
4 years ago
Reviewers:
Nico
CC:
chromium-reviews, eugenis+clang_chromium.org, vmpstr+watch_chromium.org, Lei Zhang, dsinclair, yunlian, glider+clang_chromium.org, Nico, ukai+watch_chromium.org, Reid Kleckner, hans, dmikurube+clang_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clang toolchain: link Gold plugin with lld. This is yet another step towards getting rid of Gold plugin for LTO. BUG=607968 Committed: https://crrev.com/212e4d886c91da74f296758d62c7d6a5ef87fae1 Cr-Commit-Position: refs/heads/master@{#438232}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -17 lines) Patch
M tools/clang/scripts/update.py View 2 chunks +9 lines, -17 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
krasin1
4 years ago (2016-12-13 07:52:38 UTC) #2
Nico
lgtm
4 years ago (2016-12-13 15:50:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2569813003/1
4 years ago (2016-12-13 17:24:23 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-13 18:32:57 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/212e4d886c91da74f296758d62c7d6a5ef87fae1 Cr-Commit-Position: refs/heads/master@{#438232}
4 years ago (2016-12-13 18:36:45 UTC) #10
Nico
4 years ago (2016-12-13 20:48:13 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2569323002/ by thakis@chromium.org.

The reason for reverting is: Blocks making a clang roll. Will revert this, roll,
then reland this and the fix https://codereview.chromium.org/2572833003/ , and
then roll to -2 with that..

Powered by Google App Engine
This is Rietveld 408576698