Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Unified Diff: tools/gn/secondary/third_party/libxml/BUILD.gn

Issue 25698002: (mostly) working wtf / wtf_unittests gn targets (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/gn/secondary/third_party/libxml/BUILD.gn
diff --git a/tools/gn/secondary/third_party/libxml/BUILD.gn b/tools/gn/secondary/third_party/libxml/BUILD.gn
index 2a7a3dea3fbd23e0a589801bcfff7cff237c9fe6..c60c30ece160f44e97b457cf0242d06a8e82e698 100644
--- a/tools/gn/secondary/third_party/libxml/BUILD.gn
+++ b/tools/gn/secondary/third_party/libxml/BUILD.gn
@@ -155,6 +155,14 @@ static_library("libxml2") {
ldflags = [ "-ldl" ]
}
+ if (is_mac || is_android) {
+ # http://www.xmlsoft.org/threads.html says that this is required
Nico 2013/10/02 15:56:30 Looking at that page, it seems to no longer say th
+ # when using libxml from several threads, which can possibly happen
+ # in chrome. On linux, this is picked up by transitivity from
+ # pkg-config output from build/linux/system.gyp.
+ cflags = [ "-D_REENTRANT" ]
+ }
+
if (is_clang) {
cflags = [
# libxml passes `const unsigned char*` through `const char*`.

Powered by Google App Engine
This is Rietveld 408576698