Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Side by Side Diff: tools/gn/secondary/third_party/libxml/BUILD.gn

Issue 25698002: (mostly) working wtf / wtf_unittests gn targets (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # Define an "os_include" variable that points at the OS-specific generated 5 # Define an "os_include" variable that points at the OS-specific generated
6 # headers. These were generated by running the configure script offline. 6 # headers. These were generated by running the configure script offline.
7 if (is_linux) { 7 if (is_linux) {
8 os_include = "linux" 8 os_include = "linux"
9 } else if (is_mac) { 9 } else if (is_mac) {
10 os_include = "mac" 10 os_include = "mac"
(...skipping 137 matching lines...) Expand 10 before | Expand all | Expand 10 after
148 deps = [ 148 deps = [
149 "//third_party/icu:icuuc", 149 "//third_party/icu:icuuc",
150 "//third_party/zlib:chrome_zlib", 150 "//third_party/zlib:chrome_zlib",
151 ] 151 ]
152 152
153 if (is_linux) { 153 if (is_linux) {
154 # We need dl for dlopen() and friends. 154 # We need dl for dlopen() and friends.
155 ldflags = [ "-ldl" ] 155 ldflags = [ "-ldl" ]
156 } 156 }
157 157
158 if (is_mac || is_android) {
159 # http://www.xmlsoft.org/threads.html says that this is required
Nico 2013/10/02 15:56:30 Looking at that page, it seems to no longer say th
160 # when using libxml from several threads, which can possibly happen
161 # in chrome. On linux, this is picked up by transitivity from
162 # pkg-config output from build/linux/system.gyp.
163 cflags = [ "-D_REENTRANT" ]
164 }
165
158 if (is_clang) { 166 if (is_clang) {
159 cflags = [ 167 cflags = [
160 # libxml passes `const unsigned char*` through `const char*`. 168 # libxml passes `const unsigned char*` through `const char*`.
161 "-Wno-pointer-sign", 169 "-Wno-pointer-sign",
162 170
163 # pattern.c and uri.c both have an intentional `for (...);` / 171 # pattern.c and uri.c both have an intentional `for (...);` /
164 # `while(...);` loop. I submitted a patch to move the `'` to its own 172 # `while(...);` loop. I submitted a patch to move the `'` to its own
165 # line, but until that's landed suppress the warning: 173 # line, but until that's landed suppress the warning:
166 "-Wno-empty-body", 174 "-Wno-empty-body",
167 175
168 # See http://crbug.com/138571#c8 176 # See http://crbug.com/138571#c8
169 "-Wno-ignored-attributes", 177 "-Wno-ignored-attributes",
170 ] 178 ]
171 } 179 }
172 180
173 includes = [ 181 includes = [
174 "$os_include", 182 "$os_include",
175 ] 183 ]
176 } 184 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698