When prepending "Get" to accessors, consider inheritance chain.

When prepending "Get" to accessors, consider inheritance chain.

BUG=673031
Committed: https://crrev.com/acf150930d965458fd74733d2d4ca2e4ae79e373
Cr-Commit-Position: refs/heads/master@{#438671}

[Łukasz Anforowicz, 2016-12-12 17:59:23]

lukasza@chromium.org changed reviewers:
+ dcheng@chromium.org

[Łukasz Anforowicz, 2016-12-12 17:59:24]

dcheng@, could you PTAL?

[dcheng, 2016-12-12 21:18:11]

Can you add a test case for the non-virtual case as well? I'm not yet sure if
I'm going to devirtualize more of the methods that return covariant types, but
it might be good to have coverage ((Local|Remote)?DOMWindow::frame is currently
under consideration)

[Łukasz Anforowicz, 2016-12-12 21:43:56]

On 2016/12/12 21:18:11, dcheng wrote:
> Can you add a test case for the non-virtual case as well? I'm not yet sure if
> I'm going to devirtualize more of the methods that return covariant types, but
> it might be good to have coverage ((Local|Remote)?DOMWindow::frame is
currently
> under consideration)

Done.

[dcheng, 2016-12-14 23:07:56]

lgtm

[Łukasz Anforowicz, 2016-12-14 23:08:18]

The CQ bit was checked by lukasza@chromium.org

[commit-bot: I haz the power, 2016-12-14 23:08:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 23:31:03]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481756898196710,
"parent_rev": "e537a5aea0d052291971cdc4a389368b2cb91a0e", "commit_rev":
"15638a7f36169facacc4e41c342a343f09b96cc0"}

[commit-bot: I haz the power, 2016-12-14 23:31:29]

Description was changed from

==========
When prepending "Get" to accessors, consider inheritance chain.

BUG=673031
==========

to

==========
When prepending "Get" to accessors, consider inheritance chain.

BUG=673031

Review-Url: https://codereview.chromium.org/2569783002
==========

[commit-bot: I haz the power, 2016-12-14 23:31:30]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-14 23:33:51]

Description was changed from

==========
When prepending "Get" to accessors, consider inheritance chain.

BUG=673031

Review-Url: https://codereview.chromium.org/2569783002
==========

to

==========
When prepending "Get" to accessors, consider inheritance chain.

BUG=673031

Committed: https://crrev.com/acf150930d965458fd74733d2d4ca2e4ae79e373
Cr-Commit-Position: refs/heads/master@{#438671}
==========

[commit-bot: I haz the power, 2016-12-14 23:33:52]

Patchset 2 (id:??) landed as
https://crrev.com/acf150930d965458fd74733d2d4ca2e4ae79e373
Cr-Commit-Position: refs/heads/master@{#438671}