Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 2569783002: When prepending "Get" to accessors, consider inheritance chain. (Closed)

Created:
4 years ago by Łukasz Anforowicz
Modified:
4 years ago
Reviewers:
dcheng
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

When prepending "Get" to accessors, consider inheritance chain. BUG=673031 Committed: https://crrev.com/acf150930d965458fd74733d2d4ca2e4ae79e373 Cr-Commit-Position: refs/heads/master@{#438671}

Patch Set 1 #

Patch Set 2 : Added test for non-virtual method scenario. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -3 lines) Patch
M tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp View 1 chunk +8 lines, -3 lines 0 comments Download
M tools/clang/rewrite_to_chrome_style/tests/methods-expected.cc View 1 1 chunk +33 lines, -0 lines 0 comments Download
M tools/clang/rewrite_to_chrome_style/tests/methods-original.cc View 1 1 chunk +33 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Łukasz Anforowicz
dcheng@, could you PTAL?
4 years ago (2016-12-12 17:59:24 UTC) #2
dcheng
Can you add a test case for the non-virtual case as well? I'm not yet ...
4 years ago (2016-12-12 21:18:11 UTC) #3
Łukasz Anforowicz
On 2016/12/12 21:18:11, dcheng wrote: > Can you add a test case for the non-virtual ...
4 years ago (2016-12-12 21:43:56 UTC) #4
dcheng
lgtm
4 years ago (2016-12-14 23:07:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2569783002/20001
4 years ago (2016-12-14 23:08:46 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-14 23:31:30 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-14 23:33:52 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/acf150930d965458fd74733d2d4ca2e4ae79e373
Cr-Commit-Position: refs/heads/master@{#438671}

Powered by Google App Engine
This is Rietveld 408576698