Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2569763006:
Make an existing workaround a bit broader. (Closed)
DescriptionMake an existing workaround a bit broader.
Without this, the test seems to fail after clang roll
https://codereview.chromium.org/2577523002
Since there's already a workaround, this is likely triggering
the same existing bug that already has a workaround, and not
due to a new compiler bug.
BUG=673463, 674194
TBR=tkent
Committed: https://crrev.com/299b2474f698a03d54cb12e484c389b82c47d9ca
Cr-Commit-Position: refs/heads/master@{#438595}
Patch Set 1 #
Messages
Total messages: 16 (10 generated)
Description was changed from ========== Make an existing workaround a bit broader. BUG=673463,674194 ========== to ========== Make an existing workaround a bit broader. Without this, the test seems to fail after clang roll https://codereview.chromium.org/2577523002 Since there's already a workaround, this is likely triggering the same existing bug that already has a workaround, and not due to a new compiler bug. BUG=673463,674194 ==========
thakis@chromium.org changed reviewers: + keishi@chromium.org, tkent@chromium.org
The CQ bit was checked by thakis@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The clang roll just made it through the CQ, so I'll TBR this.
Description was changed from ========== Make an existing workaround a bit broader. Without this, the test seems to fail after clang roll https://codereview.chromium.org/2577523002 Since there's already a workaround, this is likely triggering the same existing bug that already has a workaround, and not due to a new compiler bug. BUG=673463,674194 ========== to ========== Make an existing workaround a bit broader. Without this, the test seems to fail after clang roll https://codereview.chromium.org/2577523002 Since there's already a workaround, this is likely triggering the same existing bug that already has a workaround, and not due to a new compiler bug. BUG=673463,674194 TBR=tkent ==========
The CQ bit was unchecked by thakis@chromium.org
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1481741990314120, "parent_rev":
"48fdcaac9504caa7cf3a1b7cdcc16ba7547e0645", "commit_rev":
"b6d1b6dd4feaff2101b566e691197a66f9317c7f"}
Message was sent while issue was closed.
Description was changed from ========== Make an existing workaround a bit broader. Without this, the test seems to fail after clang roll https://codereview.chromium.org/2577523002 Since there's already a workaround, this is likely triggering the same existing bug that already has a workaround, and not due to a new compiler bug. BUG=673463,674194 TBR=tkent ========== to ========== Make an existing workaround a bit broader. Without this, the test seems to fail after clang roll https://codereview.chromium.org/2577523002 Since there's already a workaround, this is likely triggering the same existing bug that already has a workaround, and not due to a new compiler bug. BUG=673463,674194 TBR=tkent Review-Url: https://codereview.chromium.org/2569763006 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Make an existing workaround a bit broader. Without this, the test seems to fail after clang roll https://codereview.chromium.org/2577523002 Since there's already a workaround, this is likely triggering the same existing bug that already has a workaround, and not due to a new compiler bug. BUG=673463,674194 TBR=tkent Review-Url: https://codereview.chromium.org/2569763006 ========== to ========== Make an existing workaround a bit broader. Without this, the test seems to fail after clang roll https://codereview.chromium.org/2577523002 Since there's already a workaround, this is likely triggering the same existing bug that already has a workaround, and not due to a new compiler bug. BUG=673463,674194 TBR=tkent Committed: https://crrev.com/299b2474f698a03d54cb12e484c389b82c47d9ca Cr-Commit-Position: refs/heads/master@{#438595} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/299b2474f698a03d54cb12e484c389b82c47d9ca Cr-Commit-Position: refs/heads/master@{#438595}
Message was sent while issue was closed.
lgtm |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
