Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 2569763005: Revert of Removing trace_data from our chrome telemetry build dependency list. (Closed)

Created:
4 years ago by eyaich1
Modified:
4 years ago
CC:
benjhayden, chromium-reviews, nduca, telemetry-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Removing trace_data from our chrome telemetry build dependency list. (patchset #3 id:40001 of https://codereview.chromium.org/2556193002/ ) Reason for revert: Was only for testing purposes Original issue's description: > Removing trace_data from our chrome telemetry build dependency list. > > BUG=chromium:670284 > > Committed: https://crrev.com/7ff018563d1f7b78d5906e7478858f8931724693 > Cr-Commit-Position: refs/heads/master@{#437896} TBR=eakuefner@chromium.org,nednguyen@google.com,sullivan@chromium.org,aiolos@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:670284 Committed: https://crrev.com/5fc3682caa72c44d8a6abeecc52ff03a134018dc Cr-Commit-Position: refs/heads/master@{#438555}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -51 lines) Patch
M tools/perf/chrome_telemetry_build/BUILD.gn View 1 chunk +1 line, -51 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
eyaich1
Created Revert of Removing trace_data from our chrome telemetry build dependency list.
4 years ago (2016-12-14 17:22:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2569763005/1
4 years ago (2016-12-14 17:23:01 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-14 18:50:15 UTC) #6
commit-bot: I haz the power
4 years ago (2016-12-14 18:54:14 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5fc3682caa72c44d8a6abeecc52ff03a134018dc
Cr-Commit-Position: refs/heads/master@{#438555}

Powered by Google App Engine
This is Rietveld 408576698