Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 2569763003: improve feature detection for S3TC+sRGB textures (Closed)

Created:
4 years ago by Kai Ninomiya
Modified:
4 years ago
CC:
chromium-reviews, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

improve feature detection for S3TC+sRGB textures This should _actually_ enable WEBGL_compressed_texture_s3tc_srgb on Mac (and potentially some other platforms that support but do not advertise EXT_texture_sRGB). It will also enable it on ANGLE, once ANGLE implements the currently-draft OpenGL ES extension EXT_compressed_texture_s3tc_srgb. BUG=630498 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/21f75e536140c26df267a20dfd6475a7e87c6072 Cr-Commit-Position: refs/heads/master@{#438337}

Patch Set 1 #

Patch Set 2 : fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -7 lines) Patch
M gpu/command_buffer/service/feature_info.cc View 1 1 chunk +20 lines, -7 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
Kai Ninomiya
kbr, PTAL
4 years ago (2016-12-13 18:16:23 UTC) #7
Ken Russell (switch to Gerrit)
lgtm
4 years ago (2016-12-13 18:34:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2569763003/20001
4 years ago (2016-12-13 22:21:55 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-13 23:36:30 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-13 23:39:09 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/21f75e536140c26df267a20dfd6475a7e87c6072
Cr-Commit-Position: refs/heads/master@{#438337}

Powered by Google App Engine
This is Rietveld 408576698