Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2569753002:
Iterate CRT heap instead of process heap. (Closed)
|
Created:
4 years ago by Sigurður Ásgeirsson Modified:
4 years ago CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionIterate CRT heap instead of process heap.
BUG=671459, 671653
Committed: https://crrev.com/7fb93a524deced49ea1d5620479ea449dc0896e7
Cr-Commit-Position: refs/heads/master@{#437930}
Patch Set 1 #
Messages
Total messages: 21 (14 generated)
The CQ bit was checked by siggi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Iterate CRT heap instead of process heap. BUG=671459,671653 ========== to ========== Iterate CRT heap instead of process heap. BUG=671459,671653 ==========
siggi@chromium.org changed reviewers: + avi@chromium.org, tasak@google.com, wfh@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
The CQ bit was checked by siggi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Will for content, please, Avi for OWNERS. Tasak: FYI.
OK then. LGTM
lgtm but how do we measure memory of the process heap now?
We don't. Nor do we measure the memory of any other heap in the process. I guess it would be sane to also measure the application heap, as that won't be racy, though I don't understand why nor when we do this in the first place. Looks like we've just started running this code in earnest, hence all the crashing on races to random heaps in the process. On Mon, Dec 12, 2016 at 1:43 PM <wfh@chromium.org> wrote: > lgtm but how do we measure memory of the process heap now? > > https://codereview.chromium.org/2569753002/ > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by siggi@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1481577748124760, "parent_rev":
"8f8bbf6dcd46f0d54fd53f781d216310e3446452", "commit_rev":
"96f144f9d95c8a6539c2445cb78645f36d7965e6"}
Message was sent while issue was closed.
Description was changed from ========== Iterate CRT heap instead of process heap. BUG=671459,671653 ========== to ========== Iterate CRT heap instead of process heap. BUG=671459,671653 Review-Url: https://codereview.chromium.org/2569753002 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Iterate CRT heap instead of process heap. BUG=671459,671653 Review-Url: https://codereview.chromium.org/2569753002 ========== to ========== Iterate CRT heap instead of process heap. BUG=671459,671653 Committed: https://crrev.com/7fb93a524deced49ea1d5620479ea449dc0896e7 Cr-Commit-Position: refs/heads/master@{#437930} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/7fb93a524deced49ea1d5620479ea449dc0896e7 Cr-Commit-Position: refs/heads/master@{#437930} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
