Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Issue 2569723003: Remove non-chromeos support from src/ash/resources/BUILD.gn (Closed)

Created:
4 years ago by James Cook
Modified:
4 years ago
Reviewers:
msw
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove non-chromeos support from src/ash/resources/BUILD.gn Ash only ships on Chrome OS, so simplify our BUILD.gn files by removing all the is_win and is_chromeos conditionals. This also removes a dependency from chrome/browser/ui/BUILD.gn that existed for all use_aura builds. Aura should not require ash on Windows or Linux. BUG=666776 TEST=bots Committed: https://crrev.com/d1ba845fac867bce029d97d9a54050b31807244c Cr-Commit-Position: refs/heads/master@{#437973}

Patch Set 1 #

Patch Set 2 : cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -23 lines) Patch
M ash/resources/BUILD.gn View 1 3 chunks +11 lines, -21 lines 0 comments Download
M chrome/browser/ui/BUILD.gn View 1 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
James Cook
msw, please take a look. This is the last of the build file changes to ...
4 years ago (2016-12-13 00:13:09 UTC) #8
msw
lgtm
4 years ago (2016-12-13 00:24:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2569723003/20001
4 years ago (2016-12-13 00:49:46 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-13 00:57:27 UTC) #14
commit-bot: I haz the power
4 years ago (2016-12-13 00:59:07 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d1ba845fac867bce029d97d9a54050b31807244c
Cr-Commit-Position: refs/heads/master@{#437973}

Powered by Google App Engine
This is Rietveld 408576698