Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2569723002:
predictors: Fuzzy comparison of request priority for images. (Closed)
Descriptionpredictors: Fuzzy comparison of request priority for images.
The browser tests for ResourcePrefetchPredictor check that the actual
request priority is equal to the expected value. But for the images the
priority cannot be precisely defined because there is a race between the
preload scanner issuing fetch requests and frame view performing layout
and promoting priorities of all visible images.
BUG=650253, 673028
Committed: https://crrev.com/54585e4c963fadabad06fd785ba30df548f9ade6
Cr-Commit-Position: refs/heads/master@{#437958}
Patch Set 1 #Patch Set 2 : Rebase. #Messages
Total messages: 15 (8 generated)
alexilin@chromium.org changed reviewers: + lizeb@chromium.org, pasko@chromium.org
Hi team, This is the time to eliminate flakiness of ResourcePrefetchPredictor browser tests. One engineer has already tried to disable flaky test (all of these could be flaky, actually). See https://codereview.chromium.org/2564213002/ This CL has to be landed after https://codereview.chromium.org/2561493003/ so I'll do rebase later.
Rebased, so now it's much easier to review.
Description was changed from ========== predictors: Fuzzy comparison of request priority for images. Browser tests for ResourcePrefetchPredictor check that actual request priority equals to expected value. But for the images the priority cannot be precisely defined because there is a race between preload scanner issuing fecth request and frame view performing layout and promoting priorities of all visible images. BUG=650253,673028 ========== to ========== predictors: Fuzzy comparison of request priority for images. Browser tests for ResourcePrefetchPredictor check that actual request priority equals to expected value. But for the images the priority cannot be precisely defined because there is a race between preload scanner issuing fetch request and frame view performing layout and promoting priorities of all visible images. BUG=650253,673028 ==========
On 2016/12/12 16:43:00, alexilin wrote: > Rebased, so now it's much easier to review. lgtm
Description was changed from ========== predictors: Fuzzy comparison of request priority for images. Browser tests for ResourcePrefetchPredictor check that actual request priority equals to expected value. But for the images the priority cannot be precisely defined because there is a race between preload scanner issuing fetch request and frame view performing layout and promoting priorities of all visible images. BUG=650253,673028 ========== to ========== predictors: Fuzzy comparison of request priority for images. The browser tests for ResourcePrefetchPredictor check that the actual request priority is equal to the expected value. But for the images the priority cannot be precisely defined because there is a race between the preload scanner issuing fetch requests and frame view performing layout and promoting priorities of all visible images. BUG=650253,673028 ==========
Description was changed from ========== predictors: Fuzzy comparison of request priority for images. The browser tests for ResourcePrefetchPredictor check that the actual request priority is equal to the expected value. But for the images the priority cannot be precisely defined because there is a race between the preload scanner issuing fetch requests and frame view performing layout and promoting priorities of all visible images. BUG=650253,673028 ========== to ========== predictors: Fuzzy comparison of request priority for images. The browser tests for ResourcePrefetchPredictor check that the actual request priority is equal to the expected value. But for the images the priority cannot be precisely defined because there is a race between the preload scanner issuing fetch requests and frame view performing layout and promoting priorities of all visible images. BUG=650253,673028 ==========
lgtm
The CQ bit was checked by alexilin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481565025769660,
"parent_rev": "fb13a75d25cb68861aede171dbf2cd47fb696ea6", "commit_rev":
"4f87094298441f6722a0ba4a352db48c3080d4f4"}
Message was sent while issue was closed.
Description was changed from ========== predictors: Fuzzy comparison of request priority for images. The browser tests for ResourcePrefetchPredictor check that the actual request priority is equal to the expected value. But for the images the priority cannot be precisely defined because there is a race between the preload scanner issuing fetch requests and frame view performing layout and promoting priorities of all visible images. BUG=650253,673028 ========== to ========== predictors: Fuzzy comparison of request priority for images. The browser tests for ResourcePrefetchPredictor check that the actual request priority is equal to the expected value. But for the images the priority cannot be precisely defined because there is a race between the preload scanner issuing fetch requests and frame view performing layout and promoting priorities of all visible images. BUG=650253,673028 Review-Url: https://codereview.chromium.org/2569723002 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== predictors: Fuzzy comparison of request priority for images. The browser tests for ResourcePrefetchPredictor check that the actual request priority is equal to the expected value. But for the images the priority cannot be precisely defined because there is a race between the preload scanner issuing fetch requests and frame view performing layout and promoting priorities of all visible images. BUG=650253,673028 Review-Url: https://codereview.chromium.org/2569723002 ========== to ========== predictors: Fuzzy comparison of request priority for images. The browser tests for ResourcePrefetchPredictor check that the actual request priority is equal to the expected value. But for the images the priority cannot be precisely defined because there is a race between the preload scanner issuing fetch requests and frame view performing layout and promoting priorities of all visible images. BUG=650253,673028 Committed: https://crrev.com/54585e4c963fadabad06fd785ba30df548f9ade6 Cr-Commit-Position: refs/heads/master@{#437958} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/54585e4c963fadabad06fd785ba30df548f9ade6 Cr-Commit-Position: refs/heads/master@{#437958} |
