Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(539)

Issue 2569703003: Flip quic flags by 12/12/2016 18:30 PST (Closed)

Created:
4 years ago by Zhongyi Shi
Modified:
4 years ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Flip quic flags by 12/12/2016 18:30 PST BUG=

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M net/quic/core/quic_flags_list.h View 2 chunks +2 lines, -2 lines 2 comments Download

Depends on Patchset:

Messages

Total messages: 5 (1 generated)
Zhongyi Shi
4 years ago (2016-12-13 02:41:28 UTC) #2
Ryan Hamilton
https://codereview.chromium.org/2569703003/diff/1/net/quic/core/quic_flags_list.h File net/quic/core/quic_flags_list.h (right): https://codereview.chromium.org/2569703003/diff/1/net/quic/core/quic_flags_list.h#newcode105 net/quic/core/quic_flags_list.h:105: These two flag fips are disabling flags. Can you ...
4 years ago (2016-12-13 03:55:09 UTC) #3
Zhongyi Shi
https://codereview.chromium.org/2569703003/diff/1/net/quic/core/quic_flags_list.h File net/quic/core/quic_flags_list.h (right): https://codereview.chromium.org/2569703003/diff/1/net/quic/core/quic_flags_list.h#newcode105 net/quic/core/quic_flags_list.h:105: On 2016/12/13 03:55:09, Ryan Hamilton wrote: > These two ...
4 years ago (2016-12-13 05:00:28 UTC) #4
Ryan Hamilton
4 years ago (2016-12-13 05:40:33 UTC) #5
On 2016/12/13 05:00:28, Zhongyi Shi wrote:
>
https://codereview.chromium.org/2569703003/diff/1/net/quic/core/quic_flags_li...
> File net/quic/core/quic_flags_list.h (right):
> 
>
https://codereview.chromium.org/2569703003/diff/1/net/quic/core/quic_flags_li...
> net/quic/core/quic_flags_list.h:105: 
> On 2016/12/13 03:55:09, Ryan Hamilton wrote:
> > These two flag fips are disabling flags. Can you confirm this is intended?
> 
> Yup. The internal bug 33307008 shows these two flags were default enabled
before
> finch experiments was turned back. They will be re-enabled once the finch
> experiment is live.

LGTM!

Powered by Google App Engine
This is Rietveld 408576698