Flip quic flags by 12/12/2016 18:30 PST

net/quic/core/quic_flags_list.h

Index: net/quic/core/quic_flags_list.h
diff --git a/net/quic/core/quic_flags_list.h b/net/quic/core/quic_flags_list.h
index 5939950077da3b1dcc5c3bbe4d2224fa36dacc40..9bed32d0505fff2e252d0b2b1a9e2f4af4c185f7 100644
--- a/net/quic/core/quic_flags_list.h
+++ b/net/quic/core/quic_flags_list.h
@@ -89,7 +89,7 @@ QUIC_FLAG(bool, FLAGS_quic_release_crypto_stream_buffer, true)
 
 // Use a more conservative backoff of 2x instead of 1.5x for handshake
 // retransmissions, as well as a larger minimum.
-QUIC_FLAG(bool, FLAGS_quic_conservative_handshake_retransmits, true)
+QUIC_FLAG(bool, FLAGS_quic_conservative_handshake_retransmits, false)
 
 // If true, buffer packets while parsing public headers instead of parsing down
 // if CHLO is already buffered.
@@ -101,7 +101,7 @@ QUIC_FLAG(bool, FLAGS_quic_buffer_packets_after_chlo, false)
 QUIC_FLAG(bool, FLAGS_quic_receive_packet_once_decrypted, false)
 
 // If true, enable the Lazy FACK style loss detection in QUIC.
-QUIC_FLAG(bool, FLAGS_quic_enable_lazy_fack, true)
+QUIC_FLAG(bool, FLAGS_quic_enable_lazy_fack, false)
 

[Ryan Hamilton, 2016/12/13 03:55:09]

These two flag fips are disabling flags. Can you confirm this is intended?

[Zhongyi Shi, 2016/12/13 05:00:27]

Yup. The internal bug 33307008 shows these two flags were default enabled before
finch experiments was turned back. They will be re-enabled once the finch
experiment is live.

 // If true, do not override a connection in global map if exists. Only create
 // QUIC session if it is successfully inserted to the global map. Toss the