Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2569683003: DevTools: remove deleted registrations from the SW list if a newer version is available. (Closed)

Created:
4 years ago by pfeldman
Modified:
4 years ago
Reviewers:
dgozman, pfeldman1
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: remove deleted registrations from the SW list if a newer version is available. BUG=669684 Committed: https://crrev.com/8220d88594cf69c59c44eb184c531d914edea0fe Cr-Commit-Position: refs/heads/master@{#438259}

Patch Set 1 #

Patch Set 2 : test fixed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -12 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/service-workers-view-expected.txt View 1 2 chunks +4 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js View 3 chunks +31 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/ServiceWorkerManager.js View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
pfeldman
4 years ago (2016-12-13 01:44:49 UTC) #2
dgozman
lgtm
4 years ago (2016-12-13 05:39:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2569683003/1
4 years ago (2016-12-13 05:54:00 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/348743)
4 years ago (2016-12-13 07:34:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2569683003/20001
4 years ago (2016-12-13 18:20:09 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-13 19:45:10 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-13 19:48:57 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8220d88594cf69c59c44eb184c531d914edea0fe
Cr-Commit-Position: refs/heads/master@{#438259}

Powered by Google App Engine
This is Rietveld 408576698