Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 2569633002: exo: Avoid crash at startup when XDG_RUNTIME_DIR is not set. (Closed)

Created:
4 years ago by reveman
Modified:
4 years ago
Reviewers:
sky
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

exo: Avoid crash at startup when XDG_RUNTIME_DIR is not set. Without this check we'd crash when creating the watcher and asking for the server file descriptor from a null server instance. TBR=sky@chromium.org BUG= TEST=chrome --enable-wayland-server (without XDG_RUNTIME_DIR set) Committed: https://crrev.com/45971325317d8e5a019cfa45adc19265ab6e9a0a Cr-Commit-Position: refs/heads/master@{#437795}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/chrome_browser_main_extra_parts_exo.cc View 1 chunk +2 lines, -1 line 2 comments Download

Messages

Total messages: 10 (4 generated)
reveman
4 years ago (2016-12-11 04:49:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2569633002/1
4 years ago (2016-12-11 04:49:10 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-11 17:42:31 UTC) #6
sky
LGTM https://codereview.chromium.org/2569633002/diff/1/chrome/browser/chrome_browser_main_extra_parts_exo.cc File chrome/browser/chrome_browser_main_extra_parts_exo.cc (right): https://codereview.chromium.org/2569633002/diff/1/chrome/browser/chrome_browser_main_extra_parts_exo.cc#newcode134 chrome/browser/chrome_browser_main_extra_parts_exo.cc:134: if (wayland_server_) Maybe add a comment as to ...
4 years ago (2016-12-12 02:18:38 UTC) #7
reveman
https://codereview.chromium.org/2569633002/diff/1/chrome/browser/chrome_browser_main_extra_parts_exo.cc File chrome/browser/chrome_browser_main_extra_parts_exo.cc (right): https://codereview.chromium.org/2569633002/diff/1/chrome/browser/chrome_browser_main_extra_parts_exo.cc#newcode134 chrome/browser/chrome_browser_main_extra_parts_exo.cc:134: if (wayland_server_) On 2016/12/12 at 02:18:38, sky wrote: > ...
4 years ago (2016-12-12 11:37:36 UTC) #8
commit-bot: I haz the power
4 years ago (2016-12-12 15:09:51 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/45971325317d8e5a019cfa45adc19265ab6e9a0a
Cr-Commit-Position: refs/heads/master@{#437795}

Powered by Google App Engine
This is Rietveld 408576698