Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 2569593002: Enable WebBluetooth LayoutTests for notifications on MacOS (Closed)

Created:
4 years ago by dougt
Modified:
4 years ago
Reviewers:
scheib, ortuno
CC:
chromium-reviews, blink-reviews, haraken, scheib+watch_chromium.org, ortuno+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable WebBluetooth LayoutTests for notifications on MacOS. In Bug 607822, many MacOS tests were disabled because the underlying implementation not ready. We have since fixed many bugs, and notifications seem to be working fine. This patch removes all of web bluetooth TestExceptions and re-enables notifications on the MacOS BUG=673147 Committed: https://crrev.com/b64f718b6b3f1bc5cae3a0552fb2ce63e7b6e300 Cr-Commit-Position: refs/heads/master@{#437975}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -36 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +0 lines, -28 lines 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
dougt
4 years ago (2016-12-12 16:29:28 UTC) #7
scheib
LGTM
4 years ago (2016-12-12 20:27:07 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2569593002/1
4 years ago (2016-12-12 20:29:42 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-13 01:14:01 UTC) #14
commit-bot: I haz the power
4 years ago (2016-12-13 01:16:29 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b64f718b6b3f1bc5cae3a0552fb2ce63e7b6e300
Cr-Commit-Position: refs/heads/master@{#437975}

Powered by Google App Engine
This is Rietveld 408576698