Created test page to be used for window.history.go() tests.

Created test page to be used for window.history.go() tests.

BUG=673022
Committed: https://crrev.com/4fe552659755c59afd6e596b86569cc5ded8ea0c
Cr-Commit-Position: refs/heads/master@{#438031}

[kkhorimoto, 2016-12-09 22:39:13]

kkhorimoto@chromium.org changed reviewers:
+ eugenebut@chromium.org

[Eugene But (OOO till 7-30), 2016-12-09 23:02:16]

lgtm

https://codereview.chromium.org/2569503002/diff/1/ios/testing/data/http_serve...
File ios/testing/data/http_server_files/history_go.html (right):

https://codereview.chromium.org/2569503002/diff/1/ios/testing/data/http_serve...
ios/testing/data/http_server_files/history_go.html:15: <div
id='onLoadDiv'></div>
on-load-div

https://engdoc.corp.google.com/eng/doc/htmlcssguide.xml

https://codereview.chromium.org/2569503002/diff/1/ios/testing/data/http_serve...
File ios/testing/data/http_server_files/history_go.js (right):

https://codereview.chromium.org/2569503002/diff/1/ios/testing/data/http_serve...
ios/testing/data/http_server_files/history_go.js:42: var buttonWasTapped =
function() {
s/buttonWasTapped/onButtonTap ?

https://codereview.chromium.org/2569503002/diff/1/ios/testing/data/http_serve...
ios/testing/data/http_server_files/history_go.js:42: var buttonWasTapped =
function() {
Please add comments to all non-trivial functions

[kkhorimoto, 2016-12-13 00:29:10]

https://codereview.chromium.org/2569503002/diff/1/ios/testing/data/http_serve...
File ios/testing/data/http_server_files/history_go.html (right):

https://codereview.chromium.org/2569503002/diff/1/ios/testing/data/http_serve...
ios/testing/data/http_server_files/history_go.html:15: <div
id='onLoadDiv'></div>
On 2016/12/09 23:02:16, Eugene But wrote:
> on-load-div
> 
> https://engdoc.corp.google.com/eng/doc/htmlcssguide.xml

Done.

https://codereview.chromium.org/2569503002/diff/1/ios/testing/data/http_serve...
File ios/testing/data/http_server_files/history_go.js (right):

https://codereview.chromium.org/2569503002/diff/1/ios/testing/data/http_serve...
ios/testing/data/http_server_files/history_go.js:42: var buttonWasTapped =
function() {
On 2016/12/09 23:02:16, Eugene But wrote:
> Please add comments to all non-trivial functions

Done.

[kkhorimoto, 2016-12-13 00:29:14]

The CQ bit was checked by kkhorimoto@chromium.org

[kkhorimoto, 2016-12-13 00:29:15]

The patchset sent to the CQ was uploaded after l-g-t-m from
eugenebut@chromium.org
Link to the patchset: https://codereview.chromium.org/2569503002/#ps20001
(title: "fixed div ids, added comments")

[commit-bot: I haz the power, 2016-12-13 00:30:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kkhorimoto, 2016-12-13 01:37:55]

The CQ bit was unchecked by kkhorimoto@chromium.org

[kkhorimoto, 2016-12-13 01:40:21]

The CQ bit was checked by kkhorimoto@chromium.org

[kkhorimoto, 2016-12-13 01:40:21]

The patchset sent to the CQ was uploaded after l-g-t-m from
eugenebut@chromium.org
Link to the patchset: https://codereview.chromium.org/2569503002/#ps40001
(title: "fix goBack2")

[commit-bot: I haz the power, 2016-12-13 01:41:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 03:36:25]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481593221320050,
"parent_rev": "3aaf8bfed05cae651bfc877451601fec7eb18ae9", "commit_rev":
"9edff57e7856a3637b0c7e586442c4ddf4e8f05c"}

[commit-bot: I haz the power, 2016-12-13 03:36:51]

Description was changed from

==========
Created test page to be used for window.history.go() tests.

BUG=673022
==========

to

==========
Created test page to be used for window.history.go() tests.

BUG=673022

Review-Url: https://codereview.chromium.org/2569503002
==========

[commit-bot: I haz the power, 2016-12-13 03:36:51]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-13 03:41:00]

Description was changed from

==========
Created test page to be used for window.history.go() tests.

BUG=673022

Review-Url: https://codereview.chromium.org/2569503002
==========

to

==========
Created test page to be used for window.history.go() tests.

BUG=673022

Committed: https://crrev.com/4fe552659755c59afd6e596b86569cc5ded8ea0c
Cr-Commit-Position: refs/heads/master@{#438031}
==========

[commit-bot: I haz the power, 2016-12-13 03:41:01]

Patchset 3 (id:??) landed as
https://crrev.com/4fe552659755c59afd6e596b86569cc5ded8ea0c
Cr-Commit-Position: refs/heads/master@{#438031}