Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2569433003:
Change SecurityChips animation behavior on waterfall (Closed)
|
Created:
4 years ago by estark Modified:
4 years ago Reviewers:
Ilya Sherman CC:
chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionChange SecurityChips animation behavior on waterfall
The behavior we want to launch is animate-nonsecure-only, so update the
waterfall to that animation behavior.
BUG=
Committed: https://crrev.com/3459989e8a97b51111c0f2c1138d30431d4606d5
Cr-Commit-Position: refs/heads/master@{#437731}
Patch Set 1 #
Messages
Total messages: 17 (10 generated)
The CQ bit was checked by estark@chromium.org to run a CQ dry run
estark@chromium.org changed reviewers: + isherman@chromium.org
isherman, PTAL? Thanks!
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
LGTM, thanks.
The CQ bit was unchecked by estark@chromium.org
The CQ bit was checked by estark@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by estark@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1481335504596420, "parent_rev":
"b042e1a9e7bdf0e04b1ab30c8392a1e0bd05ac11", "commit_rev":
"8b043b5fa4b9b8f5e8ea410f724844957a71d280"}
Message was sent while issue was closed.
Description was changed from ========== Change SecurityChips animation behavior on waterfall The behavior we want to launch is animate-nonsecure-only, so update the waterfall to that animation behavior. BUG= ========== to ========== Change SecurityChips animation behavior on waterfall The behavior we want to launch is animate-nonsecure-only, so update the waterfall to that animation behavior. BUG= Review-Url: https://codereview.chromium.org/2569433003 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Change SecurityChips animation behavior on waterfall The behavior we want to launch is animate-nonsecure-only, so update the waterfall to that animation behavior. BUG= Review-Url: https://codereview.chromium.org/2569433003 ========== to ========== Change SecurityChips animation behavior on waterfall The behavior we want to launch is animate-nonsecure-only, so update the waterfall to that animation behavior. BUG= Committed: https://crrev.com/3459989e8a97b51111c0f2c1138d30431d4606d5 Cr-Commit-Position: refs/heads/master@{#437731} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/3459989e8a97b51111c0f2c1138d30431d4606d5 Cr-Commit-Position: refs/heads/master@{#437731} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
