Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 256943002: Cast: Remove logging of k{AV}PacketSentToPacer events. (Closed)

Created:
6 years, 8 months ago by imcheng
Modified:
6 years, 7 months ago
Reviewers:
Alpha Left Google
CC:
chromium-reviews, hclam+watch_chromium.org, imcheng+watch_chromium.org, hguihot+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, pwestin+watch_google.com, feature-media-reviews_chromium.org, miu+watch_chromium.org, hubbe+watch_chromium.org, mikhal+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Cast: Remove logging of k{AV}PacketSentToPacer events. We don't need to log these events since we already have kAVFrameEncoded and kAVPacketSentToNetwork. BUG=366198 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267108

Patch Set 1 #

Patch Set 2 : remove completely #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -77 lines) Patch
M media/cast/logging/encoding_event_subscriber_unittest.cc View 1 2 7 chunks +8 lines, -8 lines 0 comments Download
M media/cast/logging/logging_defines.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M media/cast/logging/logging_defines.cc View 1 2 3 chunks +0 lines, -4 lines 0 comments Download
M media/cast/logging/proto/proto_utils.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M media/cast/logging/proto/raw_events.proto View 1 1 chunk +2 lines, -2 lines 0 comments Download
M media/cast/logging/serialize_deserialize_test.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M media/cast/transport/cast_transport_sender_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/cast/transport/rtp_sender/rtp_packetizer/rtp_packetizer.h View 1 2 3 chunks +1 line, -8 lines 0 comments Download
M media/cast/transport/rtp_sender/rtp_packetizer/rtp_packetizer.cc View 1 2 3 chunks +1 line, -12 lines 0 comments Download
M media/cast/transport/rtp_sender/rtp_packetizer/rtp_packetizer_unittest.cc View 5 chunks +1 line, -19 lines 0 comments Download
M media/cast/transport/rtp_sender/rtp_sender.h View 3 chunks +0 lines, -4 lines 0 comments Download
M media/cast/transport/rtp_sender/rtp_sender.cc View 1 2 3 chunks +2 lines, -4 lines 0 comments Download
M media/cast/transport/transport_audio_sender.h View 2 chunks +0 lines, -3 lines 0 comments Download
M media/cast/transport/transport_audio_sender.cc View 1 chunk +1 line, -2 lines 0 comments Download
M media/cast/transport/transport_video_sender.h View 2 chunks +0 lines, -2 lines 0 comments Download
M media/cast/transport/transport_video_sender.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
imcheng
6 years, 8 months ago (2014-04-28 01:04:39 UTC) #1
Alpha Left Google
lgtm
6 years, 7 months ago (2014-04-29 20:51:48 UTC) #2
imcheng
The CQ bit was checked by imcheng@chromium.org
6 years, 7 months ago (2014-04-29 20:52:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/imcheng@chromium.org/256943002/80001
6 years, 7 months ago (2014-04-29 20:55:46 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-29 20:56:05 UTC) #5
commit-bot: I haz the power
Failed to apply patch for media/cast/logging/stats_event_subscriber_unittest.cc: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 7 months ago (2014-04-29 20:56:05 UTC) #6
imcheng
The CQ bit was checked by imcheng@chromium.org
6 years, 7 months ago (2014-04-29 23:09:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/imcheng@chromium.org/256943002/100001
6 years, 7 months ago (2014-04-29 23:10:27 UTC) #8
commit-bot: I haz the power
6 years, 7 months ago (2014-04-30 07:00:06 UTC) #9
Message was sent while issue was closed.
Change committed as 267108

Powered by Google App Engine
This is Rietveld 408576698