Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Side by Side Diff: media/cast/transport/rtp_sender/rtp_packetizer/rtp_packetizer_unittest.cc

Issue 256943002: Cast: Remove logging of k{AV}PacketSentToPacer events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "media/cast/transport/rtp_sender/rtp_packetizer/rtp_packetizer.h" 5 #include "media/cast/transport/rtp_sender/rtp_packetizer/rtp_packetizer.h"
6 6
7 #include <stdint.h> 7 #include <stdint.h>
8 8
9 #include "base/memory/scoped_ptr.h" 9 #include "base/memory/scoped_ptr.h"
10 #include "base/test/simple_test_tick_clock.h" 10 #include "base/test/simple_test_tick_clock.h"
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
96 96
97 DISALLOW_COPY_AND_ASSIGN(TestRtpPacketTransport); 97 DISALLOW_COPY_AND_ASSIGN(TestRtpPacketTransport);
98 }; 98 };
99 99
100 class RtpPacketizerTest : public ::testing::Test { 100 class RtpPacketizerTest : public ::testing::Test {
101 protected: 101 protected:
102 RtpPacketizerTest() 102 RtpPacketizerTest()
103 : task_runner_(new test::FakeSingleThreadTaskRunner(&testing_clock_)), 103 : task_runner_(new test::FakeSingleThreadTaskRunner(&testing_clock_)),
104 video_frame_(), 104 video_frame_(),
105 packet_storage_(&testing_clock_, kMaxPacketStorageTimeMs) { 105 packet_storage_(&testing_clock_, kMaxPacketStorageTimeMs) {
106 logging_.AddRawEventSubscriber(&subscriber_);
107 config_.sequence_number = kSeqNum; 106 config_.sequence_number = kSeqNum;
108 config_.ssrc = kSsrc; 107 config_.ssrc = kSsrc;
109 config_.payload_type = kPayload; 108 config_.payload_type = kPayload;
110 config_.max_payload_length = kMaxPacketLength; 109 config_.max_payload_length = kMaxPacketLength;
111 transport_.reset(new TestRtpPacketTransport(config_)); 110 transport_.reset(new TestRtpPacketTransport(config_));
112 pacer_.reset(new PacedSender( 111 pacer_.reset(new PacedSender(
113 &testing_clock_, &logging_, transport_.get(), task_runner_)); 112 &testing_clock_, &logging_, transport_.get(), task_runner_));
114 pacer_->RegisterVideoSsrc(config_.ssrc); 113 pacer_->RegisterVideoSsrc(config_.ssrc);
115 rtp_packetizer_.reset(new RtpPacketizer( 114 rtp_packetizer_.reset(new RtpPacketizer(
116 pacer_.get(), &packet_storage_, config_, &testing_clock_, &logging_)); 115 pacer_.get(), &packet_storage_, config_));
117 video_frame_.key_frame = false; 116 video_frame_.key_frame = false;
118 video_frame_.frame_id = 0; 117 video_frame_.frame_id = 0;
119 video_frame_.last_referenced_frame_id = kStartFrameId; 118 video_frame_.last_referenced_frame_id = kStartFrameId;
120 video_frame_.data.assign(kFrameSize, 123); 119 video_frame_.data.assign(kFrameSize, 123);
121 video_frame_.rtp_timestamp = 120 video_frame_.rtp_timestamp =
122 GetVideoRtpTimestamp(testing_clock_.NowTicks()); 121 GetVideoRtpTimestamp(testing_clock_.NowTicks());
123 } 122 }
124 123
125 virtual ~RtpPacketizerTest() {
126 logging_.RemoveRawEventSubscriber(&subscriber_);
127 }
128
129 void RunTasks(int during_ms) { 124 void RunTasks(int during_ms) {
130 for (int i = 0; i < during_ms; ++i) { 125 for (int i = 0; i < during_ms; ++i) {
131 // Call process the timers every 1 ms. 126 // Call process the timers every 1 ms.
132 testing_clock_.Advance(base::TimeDelta::FromMilliseconds(1)); 127 testing_clock_.Advance(base::TimeDelta::FromMilliseconds(1));
133 task_runner_->RunTasks(); 128 task_runner_->RunTasks();
134 } 129 }
135 } 130 }
136 131
137 base::SimpleTestTickClock testing_clock_; 132 base::SimpleTestTickClock testing_clock_;
138 scoped_refptr<test::FakeSingleThreadTaskRunner> task_runner_; 133 scoped_refptr<test::FakeSingleThreadTaskRunner> task_runner_;
139 EncodedVideoFrame video_frame_; 134 EncodedVideoFrame video_frame_;
140 PacketStorage packet_storage_; 135 PacketStorage packet_storage_;
141 RtpPacketizerConfig config_; 136 RtpPacketizerConfig config_;
142 scoped_ptr<TestRtpPacketTransport> transport_; 137 scoped_ptr<TestRtpPacketTransport> transport_;
143 LoggingImpl logging_; 138 LoggingImpl logging_;
144 SimpleEventSubscriber subscriber_;
145 scoped_ptr<PacedSender> pacer_; 139 scoped_ptr<PacedSender> pacer_;
146 scoped_ptr<RtpPacketizer> rtp_packetizer_; 140 scoped_ptr<RtpPacketizer> rtp_packetizer_;
147 141
148 DISALLOW_COPY_AND_ASSIGN(RtpPacketizerTest); 142 DISALLOW_COPY_AND_ASSIGN(RtpPacketizerTest);
149 }; 143 };
150 144
151 TEST_F(RtpPacketizerTest, SendStandardPackets) { 145 TEST_F(RtpPacketizerTest, SendStandardPackets) {
152 int expected_num_of_packets = kFrameSize / kMaxPacketLength + 1; 146 int expected_num_of_packets = kFrameSize / kMaxPacketLength + 1;
153 transport_->set_expected_number_of_packets(expected_num_of_packets); 147 transport_->set_expected_number_of_packets(expected_num_of_packets);
154 transport_->set_rtp_timestamp(video_frame_.rtp_timestamp); 148 transport_->set_rtp_timestamp(video_frame_.rtp_timestamp);
155 149
156 base::TimeTicks time; 150 base::TimeTicks time;
157 time += base::TimeDelta::FromMilliseconds(kTimestampMs); 151 time += base::TimeDelta::FromMilliseconds(kTimestampMs);
158 rtp_packetizer_->IncomingEncodedVideoFrame(&video_frame_, time); 152 rtp_packetizer_->IncomingEncodedVideoFrame(&video_frame_, time);
159 RunTasks(33 + 1); 153 RunTasks(33 + 1);
160 EXPECT_EQ(expected_num_of_packets, transport_->number_of_packets_received()); 154 EXPECT_EQ(expected_num_of_packets, transport_->number_of_packets_received());
161 std::vector<PacketEvent> packet_events;
162 subscriber_.GetPacketEventsAndReset(&packet_events);
163 int expected_num_video_sent_to_pacer_count = expected_num_of_packets;
164 int num_video_sent_to_pacer_count = 0;
165 for (std::vector<PacketEvent>::iterator it = packet_events.begin();
166 it != packet_events.end();
167 ++it) {
168 if (it->type == kVideoPacketSentToPacer)
169 num_video_sent_to_pacer_count++;
170 }
171 EXPECT_EQ(expected_num_video_sent_to_pacer_count,
172 num_video_sent_to_pacer_count);
173 } 155 }
174 156
175 TEST_F(RtpPacketizerTest, Stats) { 157 TEST_F(RtpPacketizerTest, Stats) {
176 EXPECT_FALSE(rtp_packetizer_->send_packets_count()); 158 EXPECT_FALSE(rtp_packetizer_->send_packets_count());
177 EXPECT_FALSE(rtp_packetizer_->send_octet_count()); 159 EXPECT_FALSE(rtp_packetizer_->send_octet_count());
178 // Insert packets at varying lengths. 160 // Insert packets at varying lengths.
179 int expected_num_of_packets = kFrameSize / kMaxPacketLength + 1; 161 int expected_num_of_packets = kFrameSize / kMaxPacketLength + 1;
180 transport_->set_expected_number_of_packets(expected_num_of_packets); 162 transport_->set_expected_number_of_packets(expected_num_of_packets);
181 transport_->set_rtp_timestamp(video_frame_.rtp_timestamp); 163 transport_->set_rtp_timestamp(video_frame_.rtp_timestamp);
182 164
183 testing_clock_.Advance(base::TimeDelta::FromMilliseconds(kTimestampMs)); 165 testing_clock_.Advance(base::TimeDelta::FromMilliseconds(kTimestampMs));
184 rtp_packetizer_->IncomingEncodedVideoFrame(&video_frame_, 166 rtp_packetizer_->IncomingEncodedVideoFrame(&video_frame_,
185 testing_clock_.NowTicks()); 167 testing_clock_.NowTicks());
186 RunTasks(33 + 1); 168 RunTasks(33 + 1);
187 EXPECT_EQ(expected_num_of_packets, rtp_packetizer_->send_packets_count()); 169 EXPECT_EQ(expected_num_of_packets, rtp_packetizer_->send_packets_count());
188 EXPECT_EQ(kFrameSize, rtp_packetizer_->send_octet_count()); 170 EXPECT_EQ(kFrameSize, rtp_packetizer_->send_octet_count());
189 EXPECT_EQ(expected_num_of_packets, transport_->number_of_packets_received()); 171 EXPECT_EQ(expected_num_of_packets, transport_->number_of_packets_received());
190 } 172 }
191 173
192 } // namespace transport 174 } // namespace transport
193 } // namespace cast 175 } // namespace cast
194 } // namespace media 176 } // namespace media
OLDNEW
« no previous file with comments | « media/cast/transport/rtp_sender/rtp_packetizer/rtp_packetizer.cc ('k') | media/cast/transport/rtp_sender/rtp_sender.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698