Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 2569403002: [Mac] Fix for avatar button active state and removed fast chooser profile code (Closed)

Created:
4 years ago by spqchan
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

[Mac] Fix for avatar button active state and removed fast chooser profile code - The avatar button should only be set as active if the a bubble is opened - Removed the code for the fast chooser in the cocoa files BUG=670613 Review-Url: https://codereview.chromium.org/2552423002 Cr-Commit-Position: refs/heads/master@{#437947} (cherry picked from commit 8c0be82a912cb5ef954980c924c32b99740f761c) Committed: https://chromium.googlesource.com/chromium/src/+/362edf00e6b76e166cf3096ba4675d376330a418

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -92 lines) Patch
M chrome/browser/ui/cocoa/profiles/avatar_base_controller.h View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/profiles/avatar_base_controller.mm View 2 chunks +1 line, -28 lines 0 comments Download
M chrome/browser/ui/cocoa/profiles/avatar_button_controller.mm View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/profiles/avatar_button_controller_unittest.mm View 4 chunks +3 lines, -58 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
spqchan
4 years ago (2016-12-13 23:37:11 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
362edf00e6b76e166cf3096ba4675d376330a418.

Powered by Google App Engine
This is Rietveld 408576698