[Mac] Fix for avatar button active state

[Mac] Fix for avatar button active state and removed fast chooser profile code

- The avatar button should only be set as active if the a bubble is
opened
- Removed the code for the fast chooser in the cocoa files

BUG=670613
Committed: https://crrev.com/8c0be82a912cb5ef954980c924c32b99740f761c
Cr-Commit-Position: refs/heads/master@{#437947}

[spqchan, 2016-12-06 21:22:11]

The CQ bit was checked by spqchan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-06 21:22:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-06 21:53:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-06 21:53:16]

Dry run: This issue passed the CQ dry run.

[spqchan, 2016-12-06 21:55:47]

spqchan@chromium.org changed reviewers:
+ rsesek@chromium.org

[spqchan, 2016-12-06 21:55:47]

PTAL

[Robert Sesek, 2016-12-06 21:57:43]

Why does right-clicking highlight the button but not open the menu?

[spqchan, 2016-12-06 22:02:01]

On 2016/12/06 21:57:43, Robert Sesek wrote:
> Why does right-clicking highlight the button but not open the menu?

Right clicking opens the "Fast Chooser Profile Menu", which doesn't appear if
there's no other profiles.
Now that you pointed that out though, is that bubble suppose to be phased out?

[Robert Sesek, 2016-12-06 22:03:22]

On 2016/12/06 22:02:01, spqchan wrote:
> On 2016/12/06 21:57:43, Robert Sesek wrote:
> > Why does right-clicking highlight the button but not open the menu?
> 
> Right clicking opens the "Fast Chooser Profile Menu", which doesn't appear if
> there's no other profiles.
> Now that you pointed that out though, is that bubble suppose to be phased out?

I know we phased out the fast switcher because the new menu is more optimized.
But I thought that right clicking was kept(/added-back) as an alternate to open
the left-click menu, so that users don't have to re-train.

[spqchan, 2016-12-06 22:05:30]

On 2016/12/06 22:03:22, Robert Sesek wrote:
> On 2016/12/06 22:02:01, spqchan wrote:
> > On 2016/12/06 21:57:43, Robert Sesek wrote:
> > > Why does right-clicking highlight the button but not open the menu?
> > 
> > Right clicking opens the "Fast Chooser Profile Menu", which doesn't appear
if
> > there's no other profiles.
> > Now that you pointed that out though, is that bubble suppose to be phased
out?
> 
> I know we phased out the fast switcher because the new menu is more optimized.
> But I thought that right clicking was kept(/added-back) as an alternate to
open
> the left-click menu, so that users don't have to re-train.

Out-dated code detected! I'll remove it in this CL and will ping you once it's
done.
Note, I like to keep the changes in this CL since it's more reliable to actually
check if the window is there

[Robert Sesek, 2016-12-06 22:06:56]

On 2016/12/06 22:05:30, spqchan wrote:
> On 2016/12/06 22:03:22, Robert Sesek wrote:
> > On 2016/12/06 22:02:01, spqchan wrote:
> > > On 2016/12/06 21:57:43, Robert Sesek wrote:
> > > > Why does right-clicking highlight the button but not open the menu?
> > > 
> > > Right clicking opens the "Fast Chooser Profile Menu", which doesn't appear
> if
> > > there's no other profiles.
> > > Now that you pointed that out though, is that bubble suppose to be phased
> out?
> > 
> > I know we phased out the fast switcher because the new menu is more
optimized.
> > But I thought that right clicking was kept(/added-back) as an alternate to
> open
> > the left-click menu, so that users don't have to re-train.
> 
> Out-dated code detected! I'll remove it in this CL and will ping you once it's
> done.
> Note, I like to keep the changes in this CL since it's more reliable to
actually
> check if the window is there

It seems like it's an error for to call showAvatarBubbleAnchoredAt:… and then to
have the window not be visible, though.

[spqchan, 2016-12-06 22:14:43]

On 2016/12/06 22:06:56, Robert Sesek wrote:
> On 2016/12/06 22:05:30, spqchan wrote:
> > On 2016/12/06 22:03:22, Robert Sesek wrote:
> > > On 2016/12/06 22:02:01, spqchan wrote:
> > > > On 2016/12/06 21:57:43, Robert Sesek wrote:
> > > > > Why does right-clicking highlight the button but not open the menu?
> > > > 
> > > > Right clicking opens the "Fast Chooser Profile Menu", which doesn't
appear
> > if
> > > > there's no other profiles.
> > > > Now that you pointed that out though, is that bubble suppose to be
phased
> > out?
> > > 
> > > I know we phased out the fast switcher because the new menu is more
> optimized.
> > > But I thought that right clicking was kept(/added-back) as an alternate to
> > open
> > > the left-click menu, so that users don't have to re-train.
> > 
> > Out-dated code detected! I'll remove it in this CL and will ping you once
it's
> > done.
> > Note, I like to keep the changes in this CL since it's more reliable to
> actually
> > check if the window is there
> 
> It seems like it's an error for to call showAvatarBubbleAnchoredAt:… and then
to
> have the window not be visible, though.

|showAvatarBubbleAnchoredAt:| returns without showing the window if the
menuController isn't set (in which tutorial mode will fire instead) or if the
Fast Chooser Profile Menu" is requested without any profiles.

[spqchan, 2016-12-06 23:39:41]

Description was changed from

==========
[Mac] Fix for avatar button active state

- The avatar button should only be set as active if the a bubble is
opened

BUG=670613
==========

to

==========
[Mac] Fix for avatar button active state and removed fast chooser profile code

- The avatar button should only be set as active if the a bubble is
opened
- Removed the code for the fast chooser in the cocoa files


BUG=670613
==========

[spqchan, 2016-12-06 23:40:44]

I removed the code. 

CC'ing shrike to make sure that removing this code is okay

[shrike, 2016-12-07 23:39:50]

On 2016/12/06 23:40:44, spqchan wrote:
> I removed the code. 
> 
> CC'ing shrike to make sure that removing this code is okay

I can't really comment - I'm not sure what issues are being addressed, exactly.

[spqchan, 2016-12-08 03:53:29]

On 2016/12/07 23:39:50, shrike wrote:
> On 2016/12/06 23:40:44, spqchan wrote:
> > I removed the code. 
> > 
> > CC'ing shrike to make sure that removing this code is okay
> 
> I can't really comment - I'm not sure what issues are being addressed,
exactly.

Sorry my bad. AFAIK, we're no longer using the Fast Chooser Profile Menu for
Chrome (basically what you used to get when you right click the avatar button)
I removed the code in cocoa that still references the fast choose profile menu,
but the Fash Chooser code still exists in views and etc.
Just want to double check if we still need the code or not.

[spqchan, 2016-12-12 21:50:55]

On 2016/12/08 03:53:29, spqchan wrote:
> On 2016/12/07 23:39:50, shrike wrote:
> > On 2016/12/06 23:40:44, spqchan wrote:
> > > I removed the code. 
> > > 
> > > CC'ing shrike to make sure that removing this code is okay
> > 
> > I can't really comment - I'm not sure what issues are being addressed,
> exactly.
> 
> Sorry my bad. AFAIK, we're no longer using the Fast Chooser Profile Menu for
> Chrome (basically what you used to get when you right click the avatar button)
> I removed the code in cocoa that still references the fast choose profile
menu,
> but the Fash Chooser code still exists in views and etc.
> Just want to double check if we still need the code or not.

Talked to shrike@ today at the 1:1 and it looks like everything is okay. Can you
have a look at my changes, rsesek? Thanks!

[Robert Sesek, 2016-12-12 22:06:14]

LGTM

[spqchan, 2016-12-12 22:06:48]

The CQ bit was checked by spqchan@chromium.org

[spqchan, 2016-12-12 22:06:58]

On 2016/12/12 22:06:14, Robert Sesek wrote:
> LGTM

thanks!

[commit-bot: I haz the power, 2016-12-12 22:08:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-12 23:15:24]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481580408594000,
"parent_rev": "2dc9ed29e8994006fc6612ead3d88636482103fb", "commit_rev":
"ffb90ef93eb58238d733647fdc89600dfc52737f"}

[commit-bot: I haz the power, 2016-12-12 23:15:53]

Description was changed from

==========
[Mac] Fix for avatar button active state and removed fast chooser profile code

- The avatar button should only be set as active if the a bubble is
opened
- Removed the code for the fast chooser in the cocoa files


BUG=670613
==========

to

==========
[Mac] Fix for avatar button active state and removed fast chooser profile code

- The avatar button should only be set as active if the a bubble is
opened
- Removed the code for the fast chooser in the cocoa files


BUG=670613

Review-Url: https://codereview.chromium.org/2552423002
==========

[commit-bot: I haz the power, 2016-12-12 23:15:54]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-12 23:20:27]

Description was changed from

==========
[Mac] Fix for avatar button active state and removed fast chooser profile code

- The avatar button should only be set as active if the a bubble is
opened
- Removed the code for the fast chooser in the cocoa files


BUG=670613

Review-Url: https://codereview.chromium.org/2552423002
==========

to

==========
[Mac] Fix for avatar button active state and removed fast chooser profile code

- The avatar button should only be set as active if the a bubble is
opened
- Removed the code for the fast chooser in the cocoa files

BUG=670613

Committed: https://crrev.com/8c0be82a912cb5ef954980c924c32b99740f761c
Cr-Commit-Position: refs/heads/master@{#437947}
==========

[commit-bot: I haz the power, 2016-12-12 23:20:28]

Patchset 2 (id:??) landed as
https://crrev.com/8c0be82a912cb5ef954980c924c32b99740f761c
Cr-Commit-Position: refs/heads/master@{#437947}