Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Issue 2569353003: Make ServiceWorkerStorage's UserData functions call LazyInitialize (Closed)

Created:
4 years ago by falken
Modified:
4 years ago
Reviewers:
nhiroki
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, shimazu+serviceworker_chromium.org, serviceworker-reviews, jam, nhiroki, kinuko+serviceworker, horo+watch_chromium.org, darin-cc_chromium.org, kinuko+watch, tzik, blink-worker-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make ServiceWorkerStorage's UserData functions call LazyInitialize The callers can have a registration id even before storage is initialized, for example if registration ids are stored in preferences. BUG=672716 Committed: https://crrev.com/88bb637513212580567ef844f6b6e3edc16554f7 Cr-Commit-Position: refs/heads/master@{#438748}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -8 lines) Patch
M content/browser/service_worker/service_worker_storage.cc View 3 chunks +23 lines, -8 lines 0 comments Download
M content/browser/service_worker/service_worker_storage_unittest.cc View 1 chunk +29 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
falken
ptal
4 years ago (2016-12-14 07:02:56 UTC) #2
nhiroki
lgtm
4 years ago (2016-12-15 03:41:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2569353003/1
4 years ago (2016-12-15 04:49:32 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-15 04:53:37 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-15 04:57:43 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/88bb637513212580567ef844f6b6e3edc16554f7
Cr-Commit-Position: refs/heads/master@{#438748}

Powered by Google App Engine
This is Rietveld 408576698