Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(592)

Issue 2569353002: Merge M55: Revert of Annotate Trusteer Rapport < 3.6 as incompatible with Chrome. (patchset #1 id:1… (Closed)

Created:
4 years ago by Will Harris
Modified:
4 years ago
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

Merge M55: Revert of Annotate Trusteer Rapport < 3.6 as incompatible with Chrome. (patchset #1 id:1 of https://codereview.chromium.org/2566733003/ ) Reason for revert: These issues have been resolved in the latest update from Trusteer. Original issue's description: > Annotate Trusteer Rapport < 3.6 as incompatible with Chrome. > > BUG=671194 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng > TEST=manual, install Trusteer Rapport, verify dialog appears. > > Committed: https://crrev.com/07a5425d95dc96b3d0a3bd8acad943cf0f4cd2fb > Cr-Commit-Position: refs/heads/master@{#437729} TBR=chrisha@chromium.org,jschuh@chromium.org,finnur@chromium.org,pmonette@chromium.org BUG=671194 Review-Url: https://codereview.chromium.org/2577533002 Cr-Commit-Position: refs/heads/master@{#438293} (cherry picked from commit b17b3a185ede96b5654f5ece8d19ee4f070d96ce) CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng Committed: https://chromium.googlesource.com/chromium/src/+/3992d8758269d26ad8e40b37ef6702deca3b8e2f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -17 lines) Patch
M chrome/browser/win/enumerate_modules_model.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/win/enumerate_modules_model.cc View 2 chunks +0 lines, -14 lines 0 comments Download

Messages

Total messages: 3 (2 generated)
Will Harris
4 years ago (2016-12-13 22:45:13 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3992d8758269d26ad8e40b37ef6702deca3b8e2f.

Powered by Google App Engine
This is Rietveld 408576698