Rename BookmarkIndex to TitledUrlIndex and BookmarkMatch to TitledUrlMatch

Rename BookmarkIndex to TitledUrlIndex and BookmarkMatch to TitledUrlMatch

These classes were refactored to decouple them from BookmarkModel. Now
that the refactoring is complete, rename the classes and methods to remove
references to bookmarks.

BUG=630769
Committed: https://crrev.com/25e9a31458ee9aef59ac3baa4c884c638dcbbd0a
Cr-Commit-Position: refs/heads/master@{#438640}

[mattreynolds, 2016-12-13 23:31:02]

mattreynolds@chromium.org changed reviewers:
+ mpearson@chromium.org, sky@chromium.org

[mattreynolds, 2016-12-13 23:31:02]

mpearson@chromium.org: Please review changes in //components/omnibox
sky@chromium.org: Please review changes in //components/bookmarks

This CL should contain no changes to program logic.

[Mark P, 2016-12-13 23:37:42]

On 2016/12/13 23:31:02, mattreynolds wrote:
> mailto:mpearson@chromium.org: Please review changes in //components/omnibox
components/omnibox/... lgtm

> mailto:sky@chromium.org: Please review changes in //components/bookmarks
> 
> This CL should contain no changes to program logic.

[sky, 2016-12-13 23:57:26]

LGTM

https://codereview.chromium.org/2569333003/diff/1/components/bookmarks/browse...
File components/bookmarks/browser/titled_url_index.h (right):

https://codereview.chromium.org/2569333003/diff/1/components/bookmarks/browse...
components/bookmarks/browser/titled_url_index.h:1: // Copyright 2016 The
Chromium Authors. All rights reserved.
Don't update the copyrights as this is a move.

[mattreynolds, 2016-12-14 01:14:21]

Thanks Mark and Scott!

https://codereview.chromium.org/2569333003/diff/1/components/bookmarks/browse...
File components/bookmarks/browser/titled_url_index.h (right):

https://codereview.chromium.org/2569333003/diff/1/components/bookmarks/browse...
components/bookmarks/browser/titled_url_index.h:1: // Copyright 2016 The
Chromium Authors. All rights reserved.
On 2016/12/13 23:57:26, sky wrote:
> Don't update the copyrights as this is a move.

Undone.

[mattreynolds, 2016-12-14 01:14:26]

The CQ bit was checked by mattreynolds@chromium.org

[mattreynolds, 2016-12-14 01:14:26]

The patchset sent to the CQ was uploaded after l-g-t-m from
mpearson@chromium.org, sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2569333003/#ps20001
(title: "don't update copyrights")

[commit-bot: I haz the power, 2016-12-14 01:15:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 01:37:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 01:37:12]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[mattreynolds, 2016-12-14 02:00:54]

The CQ bit was checked by mattreynolds@chromium.org

[mattreynolds, 2016-12-14 02:00:55]

The patchset sent to the CQ was uploaded after l-g-t-m from
mpearson@chromium.org, sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2569333003/#ps40001
(title: "fix profile_writer_unittest.cc")

[commit-bot: I haz the power, 2016-12-14 02:01:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 02:41:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 02:41:01]

Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[mattreynolds, 2016-12-14 20:38:37]

The CQ bit was checked by mattreynolds@chromium.org

[mattreynolds, 2016-12-14 20:38:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
mpearson@chromium.org, sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2569333003/#ps60001
(title: "fix bookmark_bridge.cc")

[commit-bot: I haz the power, 2016-12-14 20:39:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 21:52:18]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1481747917920350,
"parent_rev": "a705e7cfc6cbb68488f4968005c399b81a334c17", "commit_rev":
"7132f737f83a03c56726e3510004817da60227e9"}

[commit-bot: I haz the power, 2016-12-14 21:52:48]

Description was changed from

==========
Rename BookmarkIndex to TitledUrlIndex and BookmarkMatch to TitledUrlMatch

These classes were refactored to decouple them from BookmarkModel. Now
that the refactoring is complete, rename the classes and methods to remove
references to bookmarks.

BUG=630769
==========

to

==========
Rename BookmarkIndex to TitledUrlIndex and BookmarkMatch to TitledUrlMatch

These classes were refactored to decouple them from BookmarkModel. Now
that the refactoring is complete, rename the classes and methods to remove
references to bookmarks.

BUG=630769

Review-Url: https://codereview.chromium.org/2569333003
==========

[commit-bot: I haz the power, 2016-12-14 21:52:49]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-12-14 21:56:05]

Description was changed from

==========
Rename BookmarkIndex to TitledUrlIndex and BookmarkMatch to TitledUrlMatch

These classes were refactored to decouple them from BookmarkModel. Now
that the refactoring is complete, rename the classes and methods to remove
references to bookmarks.

BUG=630769

Review-Url: https://codereview.chromium.org/2569333003
==========

to

==========
Rename BookmarkIndex to TitledUrlIndex and BookmarkMatch to TitledUrlMatch

These classes were refactored to decouple them from BookmarkModel. Now
that the refactoring is complete, rename the classes and methods to remove
references to bookmarks.

BUG=630769

Committed: https://crrev.com/25e9a31458ee9aef59ac3baa4c884c638dcbbd0a
Cr-Commit-Position: refs/heads/master@{#438640}
==========

[commit-bot: I haz the power, 2016-12-14 21:56:06]

Patchset 4 (id:??) landed as
https://crrev.com/25e9a31458ee9aef59ac3baa4c884c638dcbbd0a
Cr-Commit-Position: refs/heads/master@{#438640}