Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 2569323002: Revert of Clang toolchain: link Gold plugin with lld. (Closed)

Created:
4 years ago by Nico
Modified:
4 years ago
Reviewers:
krasin1
CC:
chromium-reviews, eugenis+clang_chromium.org, vmpstr+watch_chromium.org, Lei Zhang, dsinclair, yunlian, glider+clang_chromium.org, Nico, ukai+watch_chromium.org, Reid Kleckner, hans, dmikurube+clang_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Clang toolchain: link Gold plugin with lld. (patchset #1 id:1 of https://codereview.chromium.org/2569813003/ ) Reason for revert: Blocks making a clang roll. Will revert this, roll, then reland this and the fix https://codereview.chromium.org/2572833003/ , and then roll to -2 with that. Original issue's description: > Clang toolchain: link Gold plugin with lld. > > This is yet another step towards getting rid of Gold plugin > for LTO. > > BUG=607968 > > Committed: https://crrev.com/212e4d886c91da74f296758d62c7d6a5ef87fae1 > Cr-Commit-Position: refs/heads/master@{#438232} TBR=krasin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=607968 Committed: https://crrev.com/b55d85ef344b55a8b3db2f8cb0de23e7d6ec633b Cr-Commit-Position: refs/heads/master@{#438277}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -9 lines) Patch
M tools/clang/scripts/update.py View 2 chunks +17 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Nico
Created Revert of Clang toolchain: link Gold plugin with lld.
4 years ago (2016-12-13 20:48:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2569323002/1
4 years ago (2016-12-13 20:48:46 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-13 20:49:56 UTC) #6
commit-bot: I haz the power
4 years ago (2016-12-13 20:52:27 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b55d85ef344b55a8b3db2f8cb0de23e7d6ec633b
Cr-Commit-Position: refs/heads/master@{#438277}

Powered by Google App Engine
This is Rietveld 408576698