Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(711)

Issue 2569313002: [MD-Settings] Add Ellipsis for the Address List Pieces. (Closed)

Created:
4 years ago by hcarmona
Modified:
4 years ago
Reviewers:
Dan Beam
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD-Settings] Add Ellipsis for the Address List Pieces. BUG=669117 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/3283e4b6ebd5009d8a6d6efffdc11489f8a0fa46 Cr-Commit-Position: refs/heads/master@{#439934}

Patch Set 1 #

Total comments: 1

Patch Set 2 : better ellipsis #

Patch Set 3 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -13 lines) Patch
M chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html View 1 2 2 chunks +27 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.js View 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/test/data/webui/settings/passwords_and_autofill_fake_data.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/webui/settings/settings_autofill_section_browsertest.js View 1 chunk +9 lines, -2 lines 0 comments Download

Messages

Total messages: 29 (21 generated)
hcarmona
PTAL, screenshot in bug. Slight difference between old and new settings: Old settings limits first ...
4 years ago (2016-12-13 19:31:59 UTC) #5
hcarmona
Got feedback from cbeisinger@ about using max-width: fit-content; PTAL
4 years ago (2016-12-15 21:51:50 UTC) #12
Dan Beam
lgtm https://codereview.chromium.org/2569313002/diff/1/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html File chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html (right): https://codereview.chromium.org/2569313002/diff/1/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html#newcode35 chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html:35: .start { nit: #addressList .start
4 years ago (2016-12-16 00:57:40 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2569313002/40001
4 years ago (2016-12-19 19:57:07 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/88959)
4 years ago (2016-12-19 21:20:51 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2569313002/40001
4 years ago (2016-12-20 22:38:10 UTC) #24
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-20 23:51:41 UTC) #27
commit-bot: I haz the power
4 years ago (2016-12-20 23:54:38 UTC) #29
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/3283e4b6ebd5009d8a6d6efffdc11489f8a0fa46
Cr-Commit-Position: refs/heads/master@{#439934}

Powered by Google App Engine
This is Rietveld 408576698