third_party/WebKit/Source/web/tests/LinkSelectionTest.cpp - Issue 2569273002: Add constructors to WebInputEvents and setters so we can work at cleaning up these public structs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/LinkSelectionTest.cpp

Issue 2569273002: Add constructors to WebInputEvents and setters so we can work at cleaning up these public structs. (Closed)

Patch Set: Fix mouse up event sender not modifying modifiers Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/tests/LinkSelectionTest.cpp

diff --git a/third_party/WebKit/Source/web/tests/LinkSelectionTest.cpp b/third_party/WebKit/Source/web/tests/LinkSelectionTest.cpp

index 2a653dc5289189e5ec4cef0ff8fe24032d8d7dbe..e327df9a8d2a8b71947622a2b1034d285529e48f 100644

--- a/third_party/WebKit/Source/web/tests/LinkSelectionTest.cpp

+++ b/third_party/WebKit/Source/web/tests/LinkSelectionTest.cpp

@@ -92,7 +92,7 @@ void LinkSelectionTestBase::emulateMouseClick(const IntPoint& clickPoint,

WebMouseEvent::MouseDown, button, clickPoint, modifiers);

event.clickCount = count;

m_webView->handleInputEvent(event);

- event.type = WebMouseEvent::MouseUp;

+ event.setType(WebMouseEvent::MouseUp);

m_webView->handleInputEvent(event);

}