third_party/WebKit/Source/web/tests/KeyboardTest.cpp - Issue 2569273002: Add constructors to WebInputEvents and setters so we can work at cleaning up these public structs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/KeyboardTest.cpp

Issue 2569273002: Add constructors to WebInputEvents and setters so we can work at cleaning up these public structs. (Closed)

Patch Set: Fix mouse up event sender not modifying modifiers Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/tests/KeyboardTest.cpp

diff --git a/third_party/WebKit/Source/web/tests/KeyboardTest.cpp b/third_party/WebKit/Source/web/tests/KeyboardTest.cpp

index b1022135392a0e247a737f0c4830dfd8268be888..e92742e3e9a4c971c65d365a27d75befed07fb72 100644

--- a/third_party/WebKit/Source/web/tests/KeyboardTest.cpp

+++ b/third_party/WebKit/Source/web/tests/KeyboardTest.cpp

@@ -57,9 +57,7 @@ class KeyboardTest : public testing::Test {

int modifiers,

WebInputEvent::Type type,

const String& key = emptyString()) {

- WebKeyboardEvent event;

- event.type = type;

- event.modifiers = modifiers;

+ WebKeyboardEvent event(type, modifiers, WebInputEvent::TimeStampForTesting);

event.text[0] = keyCode;

event.windowsKeyCode = keyCode;

event.domKey = Platform::current()->domKeyEnumFromString(key);