third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp - Issue 2569273002: Add constructors to WebInputEvents and setters so we can work at cleaning up these public structs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp

Issue 2569273002: Add constructors to WebInputEvents and setters so we can work at cleaning up these public structs. (Closed)

Patch Set: Fix mouse up event sender not modifying modifiers Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp b/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp

index 7a4065c33032681f977d5fcc886de91ef3d095a8..a04599327fd465632920842f8c32232df401979e 100644

--- a/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp

+++ b/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp

@@ -595,8 +595,8 @@ void WebDevToolsAgentImpl::inspectElementAt(int sessionId,

HitTestRequest::Move | HitTestRequest::ReadOnly |

HitTestRequest::AllowChildFrameContent;

HitTestRequest request(hitType);

- WebMouseEvent dummyEvent;

- dummyEvent.type = WebInputEvent::MouseDown;

+ WebMouseEvent dummyEvent(WebInputEvent::MouseDown, WebInputEvent::NoModifiers,

+ WTF::monotonicallyIncreasingTimeMS());

dummyEvent.x = pointInRootFrame.x;

dummyEvent.y = pointInRootFrame.y;

IntPoint transformedPoint =