Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(711)

Unified Diff: third_party/WebKit/Source/web/LinkHighlightImplTest.cpp

Issue 2569273002: Add constructors to WebInputEvents and setters so we can work at cleaning up these public structs. (Closed)
Patch Set: Fix mouse up event sender not modifying modifiers Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/LinkHighlightImplTest.cpp
diff --git a/third_party/WebKit/Source/web/LinkHighlightImplTest.cpp b/third_party/WebKit/Source/web/LinkHighlightImplTest.cpp
index 3dbb8f19d6baed34f48af03cc4b99137f5dd66a1..6d8cb19c467c19db8478d23f64711320be57c52d 100644
--- a/third_party/WebKit/Source/web/LinkHighlightImplTest.cpp
+++ b/third_party/WebKit/Source/web/LinkHighlightImplTest.cpp
@@ -78,8 +78,9 @@ TEST(LinkHighlightImplTest, verifyWebViewImplIntegration) {
webViewImpl->resize(WebSize(pageWidth, pageHeight));
webViewImpl->updateAllLifecyclePhases();
- WebGestureEvent touchEvent;
- touchEvent.type = WebInputEvent::GestureShowPress;
+ WebGestureEvent touchEvent(WebInputEvent::GestureShowPress,
+ WebInputEvent::NoModifiers,
+ WebInputEvent::TimeStampForTesting);
touchEvent.sourceDevice = WebGestureDeviceTouchscreen;
// The coordinates below are linked to absolute positions in the referenced
@@ -155,8 +156,9 @@ TEST(LinkHighlightImplTest, resetDuringNodeRemoval) {
webViewImpl->resize(WebSize(pageWidth, pageHeight));
webViewImpl->updateAllLifecyclePhases();
- WebGestureEvent touchEvent;
- touchEvent.type = WebInputEvent::GestureShowPress;
+ WebGestureEvent touchEvent(WebInputEvent::GestureShowPress,
+ WebInputEvent::NoModifiers,
+ WebInputEvent::TimeStampForTesting);
touchEvent.sourceDevice = WebGestureDeviceTouchscreen;
touchEvent.x = 20;
touchEvent.y = 20;
@@ -202,8 +204,9 @@ TEST(LinkHighlightImplTest, resetLayerTreeView) {
webViewImpl->resize(WebSize(pageWidth, pageHeight));
webViewImpl->updateAllLifecyclePhases();
- WebGestureEvent touchEvent;
- touchEvent.type = WebInputEvent::GestureShowPress;
+ WebGestureEvent touchEvent(WebInputEvent::GestureShowPress,
+ WebInputEvent::NoModifiers,
+ WebInputEvent::TimeStampForTesting);
touchEvent.sourceDevice = WebGestureDeviceTouchscreen;
touchEvent.x = 20;
touchEvent.y = 20;

Powered by Google App Engine
This is Rietveld 408576698