Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(863)

Unified Diff: chrome/browser/password_manager/password_generation_interactive_uitest.cc

Issue 2569273002: Add constructors to WebInputEvents and setters so we can work at cleaning up these public structs. (Closed)
Patch Set: Fix mouse up event sender not modifying modifiers Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/password_generation_interactive_uitest.cc
diff --git a/chrome/browser/password_manager/password_generation_interactive_uitest.cc b/chrome/browser/password_manager/password_generation_interactive_uitest.cc
index b41ec6ca0f7ec7d88a53260ee14503161019c078..88654aef0ab8302f96bd163f4a0ed77e6109d0d4 100644
--- a/chrome/browser/password_manager/password_generation_interactive_uitest.cc
+++ b/chrome/browser/password_manager/password_generation_interactive_uitest.cc
@@ -23,6 +23,7 @@
#include "content/public/test/browser_test_utils.h"
#include "net/test/embedded_test_server/embedded_test_server.h"
#include "testing/gtest/include/gtest/gtest.h"
+#include "ui/events/base_event_utils.h"
#include "ui/events/keycodes/keyboard_codes.h"
namespace {
@@ -116,9 +117,10 @@ class PasswordGenerationInteractiveTest :
}
void SendKeyToPopup(ui::KeyboardCode key) {
- content::NativeWebKeyboardEvent event;
+ content::NativeWebKeyboardEvent event(blink::WebKeyboardEvent::RawKeyDown,
+ blink::WebInputEvent::NoModifiers,
+ ui::EventTimeForNow());
majidvp 2016/12/19 20:09:52 nit: can this just be TimeStampForTesting?
dtapuska 2016/12/20 19:49:21 Done.
event.windowsKeyCode = key;
- event.type = blink::WebKeyboardEvent::RawKeyDown;
RenderViewHost()->GetWidget()->ForwardKeyboardEvent(event);
}

Powered by Google App Engine
This is Rietveld 408576698