Add constructors to WebInputEvents and setters so we can work at cleaning up these public structs.

chrome/browser/password_manager/password_generation_interactive_uitest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/command_line.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/password_manager/chrome_password_manager_client.h"
 #include "chrome/browser/password_manager/password_manager_test_base.h"
 #include "chrome/browser/password_manager/password_store_factory.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/autofill/password_generation_popup_observer.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/test/base/in_process_browser_test.h"
 #include "chrome/test/base/ui_test_utils.h"
 #include "components/autofill/core/browser/autofill_test_utils.h"
 #include "components/autofill/core/common/autofill_switches.h"
 #include "components/password_manager/core/browser/password_generation_manager.h"
 #include "components/password_manager/core/browser/test_password_store.h"
 #include "content/public/browser/render_view_host.h"
 #include "content/public/browser/render_widget_host.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/test/browser_test_utils.h"
 #include "net/test/embedded_test_server/embedded_test_server.h"
 #include "testing/gtest/include/gtest/gtest.h"
+#include "ui/events/base_event_utils.h"
 #include "ui/events/keycodes/keyboard_codes.h"
 
 namespace {
 
 class TestPopupObserver : public autofill::PasswordGenerationPopupObserver {
  public:
   TestPopupObserver()
       : popup_showing_(false),
         password_visible_(false) {}
   virtual ~TestPopupObserver() {}
@@ skipping 73 matching lines @@
     return focused_element;
   }
 
   void FocusPasswordField() {
     ASSERT_TRUE(content::ExecuteScript(
         RenderViewHost(),
         "document.getElementById('password_field').focus()"));
   }
 
   void SendKeyToPopup(ui::KeyboardCode key) {
-    content::NativeWebKeyboardEvent event;
+    content::NativeWebKeyboardEvent event(blink::WebKeyboardEvent::RawKeyDown,
+                                          blink::WebInputEvent::NoModifiers,
+                                          ui::EventTimeForNow());

[majidvp, 2016/12/19 20:09:52]

nit: can this just be TimeStampForTesting?

[dtapuska, 2016/12/20 19:49:21]

Done.

     event.windowsKeyCode = key;
-    event.type = blink::WebKeyboardEvent::RawKeyDown;
     RenderViewHost()->GetWidget()->ForwardKeyboardEvent(event);
   }
 
   bool GenerationPopupShowing() {
     return observer_.popup_showing() && observer_.password_visible();
   }
 
   bool EditingPopupShowing() {
     return observer_.popup_showing() && !observer_.password_visible();
   }
@@ skipping 88 matching lines @@
   EXPECT_FALSE(password_store->IsEmpty());
 
   // Make sure the username is correct.
   password_manager::TestPasswordStore::PasswordMap stored_passwords =
       password_store->stored_passwords();
   EXPECT_EQ(1u, stored_passwords.size());
   EXPECT_EQ(1u, stored_passwords.begin()->second.size());
   EXPECT_EQ(base::UTF8ToUTF16("something"),
             (stored_passwords.begin()->second)[0].username_value);
 }