chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc - Issue 2569273002: Add constructors to WebInputEvents and setters so we can work at cleaning up these public structs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc

Issue 2569273002: Add constructors to WebInputEvents and setters so we can work at cleaning up these public structs. (Closed)

Patch Set: Fix mouse up event sender not modifying modifiers Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« blimp/net/input_message_unittest.cc ('K') | « chrome/browser/extensions/api/web_request/web_request_apitest.cc ('k') | chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer_unittest.cc » ('j') | chrome/browser/password_manager/password_generation_interactive_uitest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc

diff --git a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc

index 773e54abacff0a5b8935428472c013472073dfae..9296b23e0edf87adf870536571eaf5edb5896d8b 100644

--- a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc

+++ b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc

@@ -511,8 +511,9 @@ TEST_F(CorePageLoadMetricsObserverTest, FirstMeaningfulPaintAfterInteraction) {

NavigateAndCommit(GURL(kDefaultTestUrl));

SimulateTimingUpdate(timing);

- blink::WebMouseEvent mouse_event;

- mouse_event.type = blink::WebInputEvent::MouseDown;

+ blink::WebMouseEvent mouse_event(blink::WebInputEvent::MouseDown,

+ blink::WebInputEvent::NoModifiers,

+ blink::WebInputEvent::TimeStampForTesting);

SimulateInputEvent(mouse_event);

timing.first_meaningful_paint = base::TimeDelta::FromMilliseconds(1000);