third_party/WebKit/Source/core/layout/ng/ng_block_node.h - Issue 2569263002: Legacy out-of-flow descendant propagation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_block_node.h

Issue 2569263002: Legacy out-of-flow descendant propagation (Closed)

Patch Set: CR fixes, also added DCHECK instead of if guards Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/ng/ng_block_node.h

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_block_node.h b/third_party/WebKit/Source/core/layout/ng/ng_block_node.h

index 2597ff81fce46adfc48ac4a178961c6c27123a9e..55dd4a3d4fcdc0c157839b363bfc4184f9289e62 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_block_node.h

+++ b/third_party/WebKit/Source/core/layout/ng/ng_block_node.h

@@ -61,6 +61,10 @@ class CORE_EXPORT NGBlockNode final : public NGLayoutInputNode {

// geometry.

NGPhysicalFragment* RunOldLayout(const NGConstraintSpace&);

+ // Call if this out-of-flow block needs to be positioned with

+ // legacy Layout.

ikilpatrick 2016/12/13 21:57:36 .nit wording. Called if this is an out-of-flow bl

atotic 2016/12/13 22:01:01 done

+ void UseOldOutOfFlowPositioning();

void UpdateLayoutBox(NGPhysicalFragment* fragment,

const NGConstraintSpace* constraint_space);