third_party/WebKit/Source/core/layout/ng/ng_block_node.cc - Issue 2569263002: Legacy out-of-flow descendant propagation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_block_node.cc

Issue 2569263002: Legacy out-of-flow descendant propagation (Closed)

Patch Set: CR fixes, also added DCHECK instead of if guards Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/ng/ng_block_node.cc

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_block_node.cc b/third_party/WebKit/Source/core/layout/ng/ng_block_node.cc

index b097278f99b5d2056f28decac13881bb4ccb9afe..a551077691ebace9990c9494627708f348ed986a 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_block_node.cc

+++ b/third_party/WebKit/Source/core/layout/ng/ng_block_node.cc

@@ -325,4 +325,10 @@ NGPhysicalFragment* NGBlockNode::RunOldLayout(

return builder.ToFragment();

}

+void NGBlockNode::UseOldOutOfFlowPositioning() {

+ DCHECK(layout_box_);

+ DCHECK(layout_box_->isOutOfFlowPositioned());

+ layout_box_->containingBlock()->insertPositionedObject(layout_box_);

} // namespace blink