Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 2569243002: Change the radio button styling to the sign-in confirmation dialog (Closed)

Created:
4 years ago by msarda
Modified:
4 years ago
Reviewers:
xiyuan
CC:
chromium-reviews, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change the radio button styling to the sign-in confirmation dialog This CL does the following changes to the radio button: * Ripple diameter is now 40px, and black with alpha (not colored) * Radio button is painted with Chrome blue: #4285F4 (not polymer purple) BUG=667665 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/052b535c63488892a84df2ffa0b230627885a05e Cr-Commit-Position: refs/heads/master@{#438312}

Patch Set 1 #

Patch Set 2 : Nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/browser/resources/signin/signin_shared_css.html View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
msarda
Please take a look.
4 years ago (2016-12-13 15:36:27 UTC) #3
xiyuan
lgtm
4 years ago (2016-12-13 17:56:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2569243002/20001
4 years ago (2016-12-13 20:36:15 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-13 22:25:42 UTC) #9
commit-bot: I haz the power
4 years ago (2016-12-13 22:29:40 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/052b535c63488892a84df2ffa0b230627885a05e
Cr-Commit-Position: refs/heads/master@{#438312}

Powered by Google App Engine
This is Rietveld 408576698