Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2569233006:
[Payments]Set card and address editor title when editing complete cards and addresses (Closed)
|
Created:
4 years ago by gogerald1 Modified:
3 years, 10 months ago Reviewers:
please use gerrit instead CC:
chromium-reviews, rouslan+payments_chromium.org, sebsg+paymentswatch_chromium.org, gogerald+paymentswatch_chromium.org, agrieve+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionSet card and address editor title when editing complete cards and addresses
BUG=674161
Committed: https://crrev.com/a7bb5795f41d2465fdd2dd5855fab304e166ea1b
Cr-Commit-Position: refs/heads/master@{#438552}
Patch Set 1 #
Total comments: 2
Patch Set 2 : address comment #
Messages
Total messages: 26 (16 generated)
Description was changed from ========== use BUG= ========== to ========== Show default edit title for card and address editor when no information is missing BUG= ==========
The CQ bit was checked by gogerald@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
gogerald@chromium.org changed reviewers: + rouslan@chromium.org
Hi rouslan@, PTAL,
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
What problem are you solving? Please describe it in a bug and set the BUG= number in the description accordingly.
Description was changed from ========== Show default edit title for card and address editor when no information is missing BUG= ========== to ========== Show default edit title for card and address editor when no information is missing BUG=674161 ==========
Description was changed from ========== Show default edit title for card and address editor when no information is missing BUG=674161 ========== to ========== Set card and address editor title when editing complete cards and addresses BUG=674161 ==========
What about the contact editor? https://codereview.chromium.org/2569233006/diff/1/chrome/android/java/src/org... File chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillAddress.java (left): https://codereview.chromium.org/2569233006/diff/1/chrome/android/java/src/org... chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillAddress.java:165: case COMPLETE: You can fix this in one line instead of two by adding this line here: editTitleResId = R.string.autofill_edit_profile;
lgtm % my comments. please merge into m-56.
ContactEditor always use "Edit contact info" as title for editing exist contacts since this CL has not been landed https://codereview.chromium.org/2529043003/. Will make it right there. https://codereview.chromium.org/2569233006/diff/1/chrome/android/java/src/org... File chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillAddress.java (left): https://codereview.chromium.org/2569233006/diff/1/chrome/android/java/src/org... chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillAddress.java:165: case COMPLETE: On 2016/12/14 16:33:55, rouslan wrote: > You can fix this in one line instead of two by adding this line here: > > editTitleResId = R.string.autofill_edit_profile; Done.
The CQ bit was checked by gogerald@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from rouslan@chromium.org Link to the patchset: https://codereview.chromium.org/2569233006/#ps20001 (title: "address comment")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
The CQ bit was checked by gogerald@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481737285776140,
"parent_rev": "2057c8a3b2c7b3b9744cf3cf7384b3105a8c34f5", "commit_rev":
"59e2b7a0920281dce79a29ceb695aae4a858a45a"}
Message was sent while issue was closed.
Description was changed from ========== Set card and address editor title when editing complete cards and addresses BUG=674161 ========== to ========== Set card and address editor title when editing complete cards and addresses BUG=674161 Review-Url: https://codereview.chromium.org/2569233006 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Set card and address editor title when editing complete cards and addresses BUG=674161 Review-Url: https://codereview.chromium.org/2569233006 ========== to ========== Set card and address editor title when editing complete cards and addresses BUG=674161 Committed: https://crrev.com/a7bb5795f41d2465fdd2dd5855fab304e166ea1b Cr-Commit-Position: refs/heads/master@{#438552} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/a7bb5795f41d2465fdd2dd5855fab304e166ea1b Cr-Commit-Position: refs/heads/master@{#438552}
Message was sent while issue was closed.
Description was changed from ========== Set card and address editor title when editing complete cards and addresses BUG=674161 Committed: https://crrev.com/a7bb5795f41d2465fdd2dd5855fab304e166ea1b Cr-Commit-Position: refs/heads/master@{#438552} ========== to ========== Set card and address editor title when editing complete cards and addresses BUG=674161 Committed: https://crrev.com/a7bb5795f41d2465fdd2dd5855fab304e166ea1b Cr-Commit-Position: refs/heads/master@{#438552} ========== |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
