Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 2569233002: Make naked values in constraint behave right in "advanced" (Closed)

Created:
4 years ago by hta - Chromium
Modified:
4 years ago
CC:
chromium-reviews, blink-reviews, haraken, tommyw+watchlist_chromium.org, mcasas+watch+mediastream_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make naked values in constraint behave right in "advanced" In "advanced" constraints, naked values are to be treated as "exact". In "basic" constraints, they should be treated as "ideal". BUG=673734 Committed: https://crrev.com/c43f9fc3ae40f693a01718627f75fe05d0fb9a80 Cr-Commit-Position: refs/heads/master@{#438484}

Patch Set 1 #

Patch Set 2 : Convince compiler all cases return #

Patch Set 3 : Update layout test for getConstraints #

Unified diffs Side-by-side diffs Delta from patch set Stats (+264 lines, -84 lines) Patch
M third_party/WebKit/LayoutTests/fast/mediastream/MediaStreamTrack-getConstraints.html View 1 2 3 chunks +25 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaConstraintsImpl.cpp View 1 12 chunks +173 lines, -65 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaConstraintsTest.cpp View 1 chunk +66 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (12 generated)
hta - Chromium
tommi for ownership, guidou for constraints knowledge.
4 years ago (2016-12-13 13:50:16 UTC) #3
tommi (sloooow) - chröme
Rs lgtm
4 years ago (2016-12-13 14:25:58 UTC) #4
Guido Urdaneta
lgtm
4 years ago (2016-12-13 15:16:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2569233002/1
4 years ago (2016-12-13 16:25:17 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_compile_dbg/builds/180264)
4 years ago (2016-12-13 16:48:28 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2569233002/20001
4 years ago (2016-12-13 17:08:47 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/349031)
4 years ago (2016-12-13 18:52:13 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2569233002/40001
4 years ago (2016-12-14 10:12:20 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-14 12:04:52 UTC) #20
commit-bot: I haz the power
4 years ago (2016-12-14 12:07:30 UTC) #22
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c43f9fc3ae40f693a01718627f75fe05d0fb9a80
Cr-Commit-Position: refs/heads/master@{#438484}

Powered by Google App Engine
This is Rietveld 408576698