Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(649)

Issue 2569223002: Add User Actions for Reading List (Closed)

Created:
4 years ago by gambard
Modified:
4 years ago
Reviewers:
rkaplow
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add User Actions for Reading List BUG=651041 Committed: https://crrev.com/7f9d7dd49708403b02a400cdd509765445ad1c73 Cr-Commit-Position: refs/heads/master@{#438186}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -0 lines) Patch
M tools/metrics/actions/actions.xml View 1 chunk +34 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
gambard
PTAL. The use is downstream and will be upstreamed soon, so we want the metrics ...
4 years ago (2016-12-13 13:21:46 UTC) #2
rkaplow
if this is in an internal repo, these should live in the internal xml. Where ...
4 years ago (2016-12-13 15:48:10 UTC) #7
gambard
Actions are living here: https://chromereviews.googleplex.com/553177013/ We plan to upstream before the end of the month.
4 years ago (2016-12-13 16:01:06 UTC) #8
rkaplow
lgtm
4 years ago (2016-12-13 16:04:30 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2569223002/1
4 years ago (2016-12-13 16:14:28 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-13 16:21:34 UTC) #14
commit-bot: I haz the power
4 years ago (2016-12-13 16:24:24 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7f9d7dd49708403b02a400cdd509765445ad1c73
Cr-Commit-Position: refs/heads/master@{#438186}

Powered by Google App Engine
This is Rietveld 408576698