|
|
Chromium Code Reviews
DescriptionAdd User Actions for Reading List
BUG=651041
Committed: https://crrev.com/7f9d7dd49708403b02a400cdd509765445ad1c73
Cr-Commit-Position: refs/heads/master@{#438186}
Patch Set 1 #
Messages
Total messages: 16 (9 generated)
gambard@chromium.org changed reviewers: + rkaplow@chromium.org
PTAL. The use is downstream and will be upstreamed soon, so we want the metrics to be upstream.
The CQ bit was checked by gambard@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
if this is in an internal repo, these should live in the internal xml. Where are these actions set?
Actions are living here: https://chromereviews.googleplex.com/553177013/ We plan to upstream before the end of the month.
lgtm
The CQ bit was checked by gambard@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1481645635517660, "parent_rev":
"e32c68a21cffb9c168a07a8d6a87c70577ec4230", "commit_rev":
"01a8ce8a7bcdee9d4072b6ad29e446207b9844f8"}
Message was sent while issue was closed.
Description was changed from ========== Add User Actions for Reading List BUG=651041 ========== to ========== Add User Actions for Reading List BUG=651041 Review-Url: https://codereview.chromium.org/2569223002 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Add User Actions for Reading List BUG=651041 Review-Url: https://codereview.chromium.org/2569223002 ========== to ========== Add User Actions for Reading List BUG=651041 Committed: https://crrev.com/7f9d7dd49708403b02a400cdd509765445ad1c73 Cr-Commit-Position: refs/heads/master@{#438186} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/7f9d7dd49708403b02a400cdd509765445ad1c73 Cr-Commit-Position: refs/heads/master@{#438186} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
