Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Issue 2569203002: Change "Google" to "Google Inc" in the inf file for the cloud printer. (Closed)

Created:
4 years ago by pastarmovj
Modified:
4 years ago
Reviewers:
Georges Khalil
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change "Google" to "Google Inc." in the inf file for the cloud printer. This change makes the manufacturer coinside with the signing authority. This is only a cosmetic change and has no implications for the driver. BUG=629512 TEST=none Committed: https://crrev.com/1bb7d6e89414eef1c3387cb45d407bf68e2e64d6 Cr-Commit-Position: refs/heads/master@{#438913}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -0 lines) Patch
M cloud_print/virtual_driver/win/install/inf/gcp_driver.inf View Binary file 0 comments Download

Messages

Total messages: 15 (7 generated)
pastarmovj
Hi Georges, can I have a stamp on this CL. It is cosmetic cleanup only. ...
4 years ago (2016-12-13 17:17:52 UTC) #3
Georges Khalil
On 2016/12/13 17:17:52, pastarmovj wrote: > Hi Georges, > > can I have a stamp ...
4 years ago (2016-12-13 18:39:31 UTC) #4
pastarmovj
On 2016/12/13 18:39:31, Georges Khalil wrote: > On 2016/12/13 17:17:52, pastarmovj wrote: > > Hi ...
4 years ago (2016-12-13 20:45:54 UTC) #5
pastarmovj
4 years ago (2016-12-13 20:46:01 UTC) #6
Georges Khalil
lgtm
4 years ago (2016-12-14 18:59:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2569203002/1
4 years ago (2016-12-15 20:25:05 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-15 20:37:35 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-15 20:39:44 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1bb7d6e89414eef1c3387cb45d407bf68e2e64d6
Cr-Commit-Position: refs/heads/master@{#438913}

Powered by Google App Engine
This is Rietveld 408576698