[ios] webViewContainingBlockedImage which does not need size argument.

[ios] webViewContainingBlockedImage which does not need size argument.

webViewContainingBlockedImage will be used in various SSL tests and
passing image_size to every call is unnecessary and simply clutters the
tests.

BUG=673520
Committed: https://crrev.com/f7bff5102552f69db92d31b3496bb197101e0770
Cr-Commit-Position: refs/heads/master@{#438589}

[Eugene But (OOO till 7-30), 2016-12-12 23:31:50]

eugenebut@chromium.org changed reviewers:
+ baxley@chromium.org

[baxley, 2016-12-13 23:27:33]

https://codereview.chromium.org/2569103002/diff/20001/ios/web/public/test/ear...
File ios/web/public/test/earl_grey/web_view_matchers.mm (right):

https://codereview.chromium.org/2569103002/diff/20001/ios/web/public/test/ear...
ios/web/public/test/earl_grey/web_view_matchers.mm:101: [session_delegate
autorelease];
Is it possible for the completion_handler to not be called and this not
released?

https://codereview.chromium.org/2569103002/diff/20001/ios/web/public/test/ear...
ios/web/public/test/earl_grey/web_view_matchers.mm:112: GREYAssert(image_loaded,
@"Failed to download image");
we're okay with not asserting on error and image not being set?

[Eugene But (OOO till 7-30), 2016-12-14 00:37:55]

https://codereview.chromium.org/2569103002/diff/20001/ios/web/public/test/ear...
File ios/web/public/test/earl_grey/web_view_matchers.mm (right):

https://codereview.chromium.org/2569103002/diff/20001/ios/web/public/test/ear...
ios/web/public/test/earl_grey/web_view_matchers.mm:101: [session_delegate
autorelease];
On 2016/12/13 23:27:33, baxley wrote:
> Is it possible for the completion_handler to not be called and this not
> released?
No based on my knowledge. Apple is very consistent with calling their callbacks.

https://codereview.chromium.org/2569103002/diff/20001/ios/web/public/test/ear...
ios/web/public/test/earl_grey/web_view_matchers.mm:112: GREYAssert(image_loaded,
@"Failed to download image");
On 2016/12/13 23:27:33, baxley wrote:
> we're okay with not asserting on error and image not being set?
When |image_loaded| is false, it means that there is no such an image on the
server and matcher simply can not operate correctly.

[baxley, 2016-12-14 14:41:05]

Thank you for clarifying. LGTM

[Eugene But (OOO till 7-30), 2016-12-14 16:21:34]

The CQ bit was checked by eugenebut@chromium.org

[commit-bot: I haz the power, 2016-12-14 16:21:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 16:25:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 16:25:26]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[Eugene But (OOO till 7-30), 2016-12-14 16:42:46]

The CQ bit was checked by eugenebut@chromium.org

[Eugene But (OOO till 7-30), 2016-12-14 16:42:46]

The patchset sent to the CQ was uploaded after l-g-t-m from baxley@chromium.org
Link to the patchset: https://codereview.chromium.org/2569103002/#ps40001
(title: "Added missing dependency")

[commit-bot: I haz the power, 2016-12-14 16:43:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Eugene But (OOO till 7-30), 2016-12-14 17:56:53]

The CQ bit was unchecked by eugenebut@chromium.org

[Eugene But (OOO till 7-30), 2016-12-14 19:21:06]

The CQ bit was checked by eugenebut@chromium.org

[commit-bot: I haz the power, 2016-12-14 19:22:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 19:29:19]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481743266108280,
"parent_rev": "a758be039180b1fc0ed25d916fb2af0212514623", "commit_rev":
"58a047adeef20f3c22770116a3b4e3677499ae4d"}

[commit-bot: I haz the power, 2016-12-14 19:29:44]

Description was changed from

==========
[ios] webViewContainingBlockedImage which does not need size argument.

webViewContainingBlockedImage will be used in various SSL tests and
passing image_size to every call is unnecessary and simply clutters the
tests.

BUG=673520
==========

to

==========
[ios] webViewContainingBlockedImage which does not need size argument.

webViewContainingBlockedImage will be used in various SSL tests and
passing image_size to every call is unnecessary and simply clutters the
tests.

BUG=673520

Review-Url: https://codereview.chromium.org/2569103002
==========

[commit-bot: I haz the power, 2016-12-14 19:29:45]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-14 19:33:54]

Description was changed from

==========
[ios] webViewContainingBlockedImage which does not need size argument.

webViewContainingBlockedImage will be used in various SSL tests and
passing image_size to every call is unnecessary and simply clutters the
tests.

BUG=673520

Review-Url: https://codereview.chromium.org/2569103002
==========

to

==========
[ios] webViewContainingBlockedImage which does not need size argument.

webViewContainingBlockedImage will be used in various SSL tests and
passing image_size to every call is unnecessary and simply clutters the
tests.

BUG=673520

Committed: https://crrev.com/f7bff5102552f69db92d31b3496bb197101e0770
Cr-Commit-Position: refs/heads/master@{#438589}
==========

[commit-bot: I haz the power, 2016-12-14 19:33:57]

Patchset 3 (id:??) landed as
https://crrev.com/f7bff5102552f69db92d31b3496bb197101e0770
Cr-Commit-Position: refs/heads/master@{#438589}