Prevent prefs_registrar unsubscribe from destroyed pref_service

Prevent prefs_registrar unsubscribe from destroyed pref_service

In some rare cases pref_change_registrar_ do not unsubscribed during the
test body, resulting unsubscribe-on-destruction, but at time of test's
class dtor execution pref_service was already destroyed.
With this CL prefs_registrar lifespan will not exeed pref_service's.

BUG=

R=dbeam@chromium.org, stevenjb@chromium.org

Committed: https://crrev.com/4f17246f4e8201d61c3c41319274beb6f51c78e6
Cr-Commit-Position: refs/heads/master@{#438481}

[palar, 2016-12-13 12:52:10]

Description was changed from

==========
Prevent prefs_registrar unsubscribe from destroyed pref_service

In some rare cases pref_change_registrar_ do not unsubscribed during the
test body, resulting unsubscribe-on-destruction, but at time of test's
class dtor execution pref_service was already desrtoyed.
With this CL prefs_registrar lifespan will not exeed pref_service's.


BUG=

R=dbeam@chromium.org, stevenjb@chromium.org
==========

to

==========
Prevent prefs_registrar unsubscribe from destroyed pref_service

In some rare cases pref_change_registrar_ do not unsubscribed during the
test body, resulting unsubscribe-on-destruction, but at time of test's
class dtor execution pref_service was already destroyed.
With this CL prefs_registrar lifespan will not exeed pref_service's.


BUG=

R=dbeam@chromium.org, stevenjb@chromium.org
==========

[stevenjb, 2016-12-13 18:21:01]

lgtm

https://codereview.chromium.org/2569083003/diff/1/chrome/browser/ui/webui/opt...
File chrome/browser/ui/webui/options/preferences_browsertest.cc (right):

https://codereview.chromium.org/2569083003/diff/1/chrome/browser/ui/webui/opt...
chrome/browser/ui/webui/options/preferences_browsertest.cc:109:
pref_change_registrar_.reset(nullptr);
nit: reset() ?

[palar, 2016-12-14 10:50:09]

The CQ bit was checked by palar@yandex-team.ru

[palar, 2016-12-14 10:50:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
stevenjb@chromium.org
Link to the patchset: https://codereview.chromium.org/2569083003/#ps20001
(title: "nit removal")

[commit-bot: I haz the power, 2016-12-14 10:50:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 11:32:22]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481712609210060,
"parent_rev": "aa01d9e4534faa385c9b33e8bfd94f0d3b94030b", "commit_rev":
"e57f6a0ee0ffe7ec142307e3e7d04241db56c5c9"}

[commit-bot: I haz the power, 2016-12-14 11:32:54]

Description was changed from

==========
Prevent prefs_registrar unsubscribe from destroyed pref_service

In some rare cases pref_change_registrar_ do not unsubscribed during the
test body, resulting unsubscribe-on-destruction, but at time of test's
class dtor execution pref_service was already destroyed.
With this CL prefs_registrar lifespan will not exeed pref_service's.


BUG=

R=dbeam@chromium.org, stevenjb@chromium.org
==========

to

==========
Prevent prefs_registrar unsubscribe from destroyed pref_service

In some rare cases pref_change_registrar_ do not unsubscribed during the
test body, resulting unsubscribe-on-destruction, but at time of test's
class dtor execution pref_service was already destroyed.
With this CL prefs_registrar lifespan will not exeed pref_service's.


BUG=

R=dbeam@chromium.org, stevenjb@chromium.org

Review-Url: https://codereview.chromium.org/2569083003
==========

[commit-bot: I haz the power, 2016-12-14 11:32:55]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-14 11:35:22]

Description was changed from

==========
Prevent prefs_registrar unsubscribe from destroyed pref_service

In some rare cases pref_change_registrar_ do not unsubscribed during the
test body, resulting unsubscribe-on-destruction, but at time of test's
class dtor execution pref_service was already destroyed.
With this CL prefs_registrar lifespan will not exeed pref_service's.


BUG=

R=dbeam@chromium.org, stevenjb@chromium.org

Review-Url: https://codereview.chromium.org/2569083003
==========

to

==========
Prevent prefs_registrar unsubscribe from destroyed pref_service

In some rare cases pref_change_registrar_ do not unsubscribed during the
test body, resulting unsubscribe-on-destruction, but at time of test's
class dtor execution pref_service was already destroyed.
With this CL prefs_registrar lifespan will not exeed pref_service's.

BUG=

R=dbeam@chromium.org, stevenjb@chromium.org

Committed: https://crrev.com/4f17246f4e8201d61c3c41319274beb6f51c78e6
Cr-Commit-Position: refs/heads/master@{#438481}
==========

[commit-bot: I haz the power, 2016-12-14 11:35:23]

Patchset 2 (id:??) landed as
https://crrev.com/4f17246f4e8201d61c3c41319274beb6f51c78e6
Cr-Commit-Position: refs/heads/master@{#438481}