Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2569063002: Tighten expectations for 3 flaky animated compositing tests. (Closed)

Created:
4 years ago by Stephen Chennney
Modified:
4 years ago
Reviewers:
chrishtr
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Tighten expectations for 3 flaky animated compositing tests. These 3 tests are flaky when run in random order or even alone. As a first step in improving them, modify the tests to get away from setTimeout and to verify that the pauseAnimationAPI is working. This is unlikely to resolve the flakiness, but it will help narrow the cause. R=chrishtr BUG=653722 Review-Url: https://codereview.chromium.org/2569063002

Patch Set 1 #

Total comments: 2

Patch Set 2 : New baselines #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -12 lines) Patch
M third_party/WebKit/LayoutTests/compositing/reflections/nested-reflection-anchor-point.html View 2 chunks +6 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/compositing/reflections/nested-reflection-animated.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/compositing/reflections/nested-reflection-animated-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/compositing/reflections/nested-reflection-transition.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/compositing/reflections/nested-reflection-transition-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/compositing/reflections/nested-reflection-animated-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/compositing/reflections/nested-reflection-transition-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/compositing/reflections/nested-reflection-animated-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/compositing/reflections/nested-reflection-transition-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/compositing/reflections/nested-reflection-animated-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/compositing/reflections/nested-reflection-transition-expected.png View 1 Binary file 0 comments Download

Messages

Total messages: 13 (6 generated)
Stephen Chennney
Step 1 in resolving flakiness issues with compositing and painting tests.
4 years ago (2016-12-12 22:07:27 UTC) #2
chrishtr
https://codereview.chromium.org/2569063002/diff/1/third_party/WebKit/LayoutTests/compositing/reflections/nested-reflection-animated.html File third_party/WebKit/LayoutTests/compositing/reflections/nested-reflection-animated.html (right): https://codereview.chromium.org/2569063002/diff/1/third_party/WebKit/LayoutTests/compositing/reflections/nested-reflection-animated.html#newcode45 third_party/WebKit/LayoutTests/compositing/reflections/nested-reflection-animated.html:45: [0.5, "inner", "webkitTransform.0", 0.707107, 0.000001], Why did this change?
4 years ago (2016-12-12 22:19:07 UTC) #3
Stephen Chennney
https://codereview.chromium.org/2569063002/diff/1/third_party/WebKit/LayoutTests/compositing/reflections/nested-reflection-animated.html File third_party/WebKit/LayoutTests/compositing/reflections/nested-reflection-animated.html (right): https://codereview.chromium.org/2569063002/diff/1/third_party/WebKit/LayoutTests/compositing/reflections/nested-reflection-animated.html#newcode45 third_party/WebKit/LayoutTests/compositing/reflections/nested-reflection-animated.html:45: [0.5, "inner", "webkitTransform.0", 0.707107, 0.000001], On 2016/12/12 22:19:07, chrishtr ...
4 years ago (2016-12-12 22:52:42 UTC) #4
chrishtr
lgtm
4 years ago (2016-12-12 22:53:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2569063002/20001
4 years ago (2016-12-14 18:03:23 UTC) #8
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/2e4858e7eef2135034ed003e58a380e0813da9e6 Cr-Commit-Position: refs/heads/master@{#438608}
4 years ago (2016-12-14 20:34:35 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-14 20:34:39 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001)

Powered by Google App Engine
This is Rietveld 408576698