Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 2569023002: Fix JBig2 decoding logic (Closed)

Created:
4 years ago by Wei Li
Modified:
4 years ago
Reviewers:
Tom Sepez, dsinclair
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Fix JBig2 decoding logic While decoding among instances, variable "FIRSTS" should hold its value, not be reset. This was accidently changed by earlier refactoring. BUG=chromium:625848, pdfium:636 Review-Url: https://codereview.chromium.org/2569023002 Committed: https://pdfium.googlesource.com/pdfium/+/8d5d00b7270c198f9bfafcbd764ba0eff70fd5b1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M core/fxcodec/jbig2/JBig2_TrdProc.cpp View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
Wei Li
pls review, thanks
4 years ago (2016-12-12 21:52:08 UTC) #6
dsinclair
lgtm
4 years ago (2016-12-12 21:58:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2569023002/1
4 years ago (2016-12-12 21:58:23 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://pdfium.googlesource.com/pdfium/+/8d5d00b7270c198f9bfafcbd764ba0eff70fd5b1
4 years ago (2016-12-12 21:58:41 UTC) #12
Tom Sepez
4 years ago (2016-12-12 21:58:45 UTC) #13
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698