Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2569013005: [gpu_tests] Disable flaky pixel tests (Closed)

Created:
4 years ago by nednguyen
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[gpu_tests] Disable flaky pixel tests BUG=672999 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=kbr@chromium.org,zmo@chromium.org Committed: https://crrev.com/e3e722f67a0b233f7291532478516434a6fe3bcb Cr-Commit-Position: refs/heads/master@{#438166}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M content/test/gpu/gpu_tests/pixel_expectations.py View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2569013005/1
4 years ago (2016-12-13 13:05:17 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-13 14:45:13 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e3e722f67a0b233f7291532478516434a6fe3bcb Cr-Commit-Position: refs/heads/master@{#438166}
4 years ago (2016-12-13 14:48:05 UTC) #9
Ken Russell (switch to Gerrit)
4 years ago (2016-12-13 20:11:22 UTC) #10
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2569843004/ by kbr@chromium.org.

The reason for reverting is: These tests failed catastrophically three times on
December 9 on Windows and Mac OS. The runs all timed out. If this had been
persistent, I'd be worried and would agree with this disabling -- but looking
again, they've failed once on December 11 and once on December 12. Disabling
them wholesale is unwarranted.
.

Powered by Google App Engine
This is Rietveld 408576698