Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2569013003:
Use an enum instead of a bool for a parameter. (Closed)
DescriptionUse an enum instead of a bool for a parameter.
No intended behavior change.
BUG=
Committed: https://crrev.com/42887ff92f60a083e9307cc42acfd9277d32bcc4
Cr-Commit-Position: refs/heads/master@{#438610}
Patch Set 1 #
Messages
Total messages: 22 (11 generated)
The CQ bit was checked by thakis@chromium.org to run a CQ dry run
thakis@chromium.org changed reviewers: + rajendrant@chromium.org
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2016/12/12 22:23:24, Nico wrote: lgtm Is this needed for http://crbug.com/668207 as well ?
On 2016/12/12 23:05:54, Raj wrote: > On 2016/12/12 22:23:24, Nico wrote: > > lgtm > > Is this needed for http://crbug.com/668207 as well ? No, this here has no behavior change, I just find it a bit easier to read.
The CQ bit was unchecked by thakis@chromium.org
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
thakis@chromium.org changed reviewers: + bengr@chromium.org
+bengr for OWNERS
bengr: ping
On 2016/12/14 19:37:01, Nico wrote: > bengr: ping Nico: You could try committing now, after rebase. I have added myself as reviewer.
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1481745021438750, "parent_rev":
"cd8e29080c018bb21e73797eacbf4ede25175c30", "commit_rev":
"402016d4f0ef75ed562202a21f1e2e462e266182"}
Message was sent while issue was closed.
Description was changed from ========== Use an enum instead of a bool for a parameter. No intended behavior change. BUG= ========== to ========== Use an enum instead of a bool for a parameter. No intended behavior change. BUG= Review-Url: https://codereview.chromium.org/2569013003 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Use an enum instead of a bool for a parameter. No intended behavior change. BUG= Review-Url: https://codereview.chromium.org/2569013003 ========== to ========== Use an enum instead of a bool for a parameter. No intended behavior change. BUG= Committed: https://crrev.com/42887ff92f60a083e9307cc42acfd9277d32bcc4 Cr-Commit-Position: refs/heads/master@{#438610} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/42887ff92f60a083e9307cc42acfd9277d32bcc4 Cr-Commit-Position: refs/heads/master@{#438610} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
