Script for summarizing Windows binary section sizes

Script for summarizing Windows binary section sizes

When trying to do build-size optimizations it is handy to be able to
easily measure progress. This script summarizes the memory and file
sizes of each PE (Portable Executable) section and can print the
differences between two versions of the same binary.

This tool is mostly used to measure progress, but can also be used to
help understand where a regression has come from - what section has
grown larger.

BUG=630755
Committed: https://crrev.com/bd1071cd2d2b9b79a849e3c82857c552fb31e7bb
Cr-Commit-Position: refs/heads/master@{#438366}

[brucedawson, 2016-12-12 21:24:26]

The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run

[brucedawson, 2016-12-12 21:25:09]

brucedawson@chromium.org changed reviewers:
+ stanisc@chromium.org

[brucedawson, 2016-12-12 21:25:10]

Another script for investigating binary size regressions. PTAL when you have a
chance.

[commit-bot: I haz the power, 2016-12-12 21:26:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-12 22:41:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-12 22:41:29]

Dry run: This issue passed the CQ dry run.

[stanisc, 2016-12-13 22:58:54]

lgtm with a couple of questions

https://codereview.chromium.org/2568973003/diff/1/tools/win/pe_summarize.py
File tools/win/pe_summarize.py (right):

https://codereview.chromium.org/2568973003/diff/1/tools/win/pe_summarize.py#n...
tools/win/pe_summarize.py:68: vs_dir = r'C:\Program Files (x86)\Microsoft Visual
Studio 14.0'
Does this assume VS is installed or it just adds all possible paths where
dumpbin could be located?

https://codereview.chromium.org/2568973003/diff/1/tools/win/pe_summarize.py#n...
tools/win/pe_summarize.py:103: # Print the sizes in decimal MB. This makes large
numbers easier to
This is a bit unusual, but I guess it doesn't matter much for the tool purpose.

https://codereview.chromium.org/2568973003/diff/1/tools/win/pe_summarize.py#n...
tools/win/pe_summarize.py:121: assert(results[i][0] == last_results[i][0])
Why is this?

[brucedawson, 2016-12-14 00:30:23]

https://codereview.chromium.org/2568973003/diff/1/tools/win/pe_summarize.py
File tools/win/pe_summarize.py (right):

https://codereview.chromium.org/2568973003/diff/1/tools/win/pe_summarize.py#n...
tools/win/pe_summarize.py:68: vs_dir = r'C:\Program Files (x86)\Microsoft Visual
Studio 14.0'
I'm not sure why I was adding two directories. I think it's because if you run
dumpbin from the first you need the second, but if you run it from the second
you don't need the first!

I now just add the second, and I check for the existence of dumpbin.exe and
print a message about installing VS if it isn't found.

https://codereview.chromium.org/2568973003/diff/1/tools/win/pe_summarize.py#n...
tools/win/pe_summarize.py:103: # Print the sizes in decimal MB. This makes large
numbers easier to
On 2016/12/13 22:58:53, stanisc wrote:
> This is a bit unusual, but I guess it doesn't matter much for the tool
purpose.

Yeah, I'm a pretty strong believer in decimal for sizes.

https://codereview.chromium.org/2568973003/diff/1/tools/win/pe_summarize.py#n...
tools/win/pe_summarize.py:121: assert(results[i][0] == last_results[i][0])
On 2016/12/13 22:58:53, stanisc wrote:
> Why is this?

Comment and error message added.

[brucedawson, 2016-12-14 00:30:31]

The CQ bit was checked by brucedawson@chromium.org

[brucedawson, 2016-12-14 00:30:32]

The patchset sent to the CQ was uploaded after l-g-t-m from stanisc@chromium.org
Link to the patchset: https://codereview.chromium.org/2568973003/#ps20001
(title: "Code review tweaks")

[commit-bot: I haz the power, 2016-12-14 00:30:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 00:41:19]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481675431903750,
"parent_rev": "fd5442e48b62eabde189ff549a971334fff3f1c5", "commit_rev":
"3861452d3b921b5fa699acb27ba689fe241a4359"}

[commit-bot: I haz the power, 2016-12-14 00:41:45]

Description was changed from

==========
Script for summarizing Windows binary section sizes

When trying to do build-size optimizations it is handy to be able to
easily measure progress. This script summarizes the memory and file
sizes of each PE (Portable Executable) section and can print the
differences between two versions of the same binary.

This tool is mostly used to measure progress, but can also be used to
help understand where a regression has come from - what section has
grown larger.

BUG=630755
==========

to

==========
Script for summarizing Windows binary section sizes

When trying to do build-size optimizations it is handy to be able to
easily measure progress. This script summarizes the memory and file
sizes of each PE (Portable Executable) section and can print the
differences between two versions of the same binary.

This tool is mostly used to measure progress, but can also be used to
help understand where a regression has come from - what section has
grown larger.

BUG=630755

Review-Url: https://codereview.chromium.org/2568973003
==========

[commit-bot: I haz the power, 2016-12-14 00:41:46]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-14 00:43:42]

Description was changed from

==========
Script for summarizing Windows binary section sizes

When trying to do build-size optimizations it is handy to be able to
easily measure progress. This script summarizes the memory and file
sizes of each PE (Portable Executable) section and can print the
differences between two versions of the same binary.

This tool is mostly used to measure progress, but can also be used to
help understand where a regression has come from - what section has
grown larger.

BUG=630755

Review-Url: https://codereview.chromium.org/2568973003
==========

to

==========
Script for summarizing Windows binary section sizes

When trying to do build-size optimizations it is handy to be able to
easily measure progress. This script summarizes the memory and file
sizes of each PE (Portable Executable) section and can print the
differences between two versions of the same binary.

This tool is mostly used to measure progress, but can also be used to
help understand where a regression has come from - what section has
grown larger.

BUG=630755

Committed: https://crrev.com/bd1071cd2d2b9b79a849e3c82857c552fb31e7bb
Cr-Commit-Position: refs/heads/master@{#438366}
==========

[commit-bot: I haz the power, 2016-12-14 00:43:43]

Patchset 2 (id:??) landed as
https://crrev.com/bd1071cd2d2b9b79a849e3c82857c552fb31e7bb
Cr-Commit-Position: refs/heads/master@{#438366}