common/lhttp: only retry transient errors

common/lhttp: only retry transient errors

Currently, the NewRequest function defaults to retry.Default which always
retries on errors. Wrap this with retry.TransientOnly to make sure that
only transient errors responses (such as 5xx codes) are retried, and
hard failures are not retried (such as 403).

R=dsansome@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2568953004
Committed: https://github.com/luci/luci-go/commit/246b0478f1c7a18983c7f0a6dc721a8e0a9dabf1

[djd-OOO-Apr2017, 2016-12-13 02:10:47]

Description was changed from

==========
common/lhttp: only retry transient errors

Currently, the NewRequest function default to retry.Default which always
retries on errors. Wrap this with retry.TransientOnly to make sure that
only transient errors responses (such as 5xx codes) are retried, and
hard failures are not retried (such as 403).

R=dsansome@chromium.org
BUG=
==========

to

==========
common/lhttp: only retry transient errors

Currently, the NewRequest function defaults to retry.Default which always
retries on errors. Wrap this with retry.TransientOnly to make sure that
only transient errors responses (such as 5xx codes) are retried, and
hard failures are not retried (such as 403).

R=dsansome@chromium.org
BUG=
==========

[M-A Ruel, 2016-12-13 02:25:49]

maruel@chromium.org changed reviewers:
+ maruel@chromium.org

[M-A Ruel, 2016-12-13 02:25:49]

lgtm, thanks!

[djd-OOO-Apr2017, 2016-12-13 02:27:37]

The CQ bit was checked by djd@chromium.org

[commit-bot: I haz the power, 2016-12-13 02:27:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dsansome-google, 2016-12-13 02:36:13]

dsansome@google.com changed reviewers:
+ dsansome@google.com

[dsansome-google, 2016-12-13 02:36:14]

lgtm

Thanks for fixing this!

https://codereview.chromium.org/2568953004/diff/1/common/lhttp/client.go
File common/lhttp/client.go (right):

https://codereview.chromium.org/2568953004/diff/1/common/lhttp/client.go#newc...
common/lhttp/client.go:43: // If rFn is nil, NewRequest will use a default
exponential backoff strategy only
Wrap to 80-chars like the other comments

[commit-bot: I haz the power, 2016-12-13 02:39:04]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481596057773430, "parent_rev":
"64707122e72f7405ce9b04b38323cf8bbf7cbf2d", "commit_rev":
"246b0478f1c7a18983c7f0a6dc721a8e0a9dabf1"}

[commit-bot: I haz the power, 2016-12-13 02:39:06]

Description was changed from

==========
common/lhttp: only retry transient errors

Currently, the NewRequest function defaults to retry.Default which always
retries on errors. Wrap this with retry.TransientOnly to make sure that
only transient errors responses (such as 5xx codes) are retried, and
hard failures are not retried (such as 403).

R=dsansome@chromium.org
BUG=
==========

to

==========
common/lhttp: only retry transient errors

Currently, the NewRequest function defaults to retry.Default which always
retries on errors. Wrap this with retry.TransientOnly to make sure that
only transient errors responses (such as 5xx codes) are retried, and
hard failures are not retried (such as 403).

R=dsansome@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2568953004
Committed:
https://github.com/luci/luci-go/commit/246b0478f1c7a18983c7f0a6dc721a8e0a9dabf1
==========

[commit-bot: I haz the power, 2016-12-13 02:39:07]

Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/246b0478f1c7a18983c7f0a6dc721a8e0a9dabf1